Rename queue index to queue number
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 25 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | transport-pci: Refer to the vq by its numbertransport-pci.tex | +3 | 1 reply | |
| 2/3 | transport-mmio: Rename QueueNum registertransport-mmio.tex | +4 | 2 replies | |
| 3/3 | transport-mmio: Refer to the vq by its numbertransport-mmio.tex | +4 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Pirko |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Rename queue index to queue number
1. Currently, virtqueue is identified between driver and device interchangeably using either number of index terminology.
2. Between PCI and MMIO transport the queue size (depth) is defined as queue_size and QueueNum respectively.
To avoid confusion and to have consistency, unify them to use as Number.
Solution:
Use virtqueue number description, and rename MMIO register as QueueSize.
Patch summary:
patch-1 renames index to number for pci transport patch-2 renames mmio register from Num to Size patch-3 renames index to number for mmio transport
Please review.
This series fixes the issue [1].
This series is on top of [2].
[1] https://github.com/oasis-tcs/virtio-spec/issues/163
[2] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00527.html
---
Cornelia:
I was not sure about ccw for vq_config_block and vq_info_block structures index field refers to the queue number or not.
Can you please clarify?
If it vqn, I will send v1 by replacing index to vqn to be consistent with other part of the spec which also uses vqn.
Parav Pandit (3):
transport-pci: Refer to the vq by its number
transport-mmio: Rename QueueNum register
transport-mmio: Refer to the vq by its number
transport-mmio.tex | 16 ++++++++-------- transport-pci.tex | 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2