Skip to content

migrate_pages: fix deadlock in batched synchronous migration

Huang Ying linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3migrate_pages: fix deadlock in batched migrationmm/migrate.c+19 -434 replies
2/3migrate_pages: move split folios processing out of migrate_pages_batch()mm/migrate.c+26 -503 replies
3/3migrate_pages: try migrate in batch asynchronously firstlymm/migrate.c+55 -109 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchHugh DickinsBaolin Wang
1/3
2/3R-b
3/3T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] migrate_pages: fix deadlock in batched synchronous migration

Two deadlock bugs were reported for the migrate_pages() batching series. Thanks Hugh and Pengfei. Analysis shows that if we have locked some other folios except the one we are migrating, it's not safe in general to wait synchronously, for example, to wait the writeback to complete or wait to lock the buffer head.

So 1/3 fixes the deadlock in a simple way, where the batching support for the synchronous migration is disabled. The change is straightforward and easy to be understood. While 3/3 re-introduce the batching for synchronous migration via trying to migrate asynchronously in batch optimistically, then fall back to migrate synchronously one by one for fail-to-migrate folios. Test shows that this can restore the TLB flushing batching performance for synchronous migration effectively.

Best Regards,
Huang, Ying