Skip to content

StarFive's Pulse Width Modulation driver support

William Qiu linux-devicetree linux-pwm linux-riscv lkml 12 versions – Applied

Status from this message: Applied to riscv-dt-for-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest4 patches 14 repliesApplied
  2. v94 patches 6 repliesSuperseded
  3. v84 patches 4 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v74 patches12 repliesSuperseded
v64 patches15 repliesSuperseded
v54 patches6 repliesSuperseded
v4 RFC posting 2/24 patches9 repliesSuperseded
v4 posting 1/24 patches2 repliesSuperseded
v3 posting 2/22 patches3 repliesSuperseded
v3 posting 1/22 patches0 repliesSuperseded
v22 patches2 repliesSuperseded
v12 patches6 repliesSuperseded

Changes in v10 from the cover letter

- Rebased to v6.7rc6.
- Dropped unuseful dependency.
- Added error handling.

Patches in v10 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: pwm: Add bindings for OpenCores PWM ControllerDocumentation/devicetree/bindings/pwm/opencores,pwm.yaml+55 -03 replies
2/4pwm: opencores: Add PWM driver supportMAINTAINERS drivers/pwm/Kconfig drivers/pwm/Makefile +1 more+253 -04 replies
3/4riscv: dts: starfive: jh7100: Add PWM node and pins configurationarch/riscv/boot/dts/starfive/jh7100-common.dtsi arch/riscv/boot/dts/starfive/jh7100.dtsi+33 -04 replies
4/4riscv: dts: starfive: jh7110: Add PWM node and pins configurationarch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi arch/riscv/boot/dts/starfive/jh7110.dtsi+31 -01 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchHal FengConor DooleyEmil Renner BerthingUwe Kleine-König
1/4R-b R-b R-b A-b
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH v10 0/4] StarFive's Pulse Width Modulation driver support

Hi,

This patchset adds initial rudimentary support for the StarFive Pulse Width Modulation controller driver. And this driver will be used in StarFive's VisionFive 2 board.The first patch add Documentations for the device and Patch 2 adds device probe for the module.

Changes v9->v10:
- Rebased to v6.7rc6.
- Dropped unuseful dependency.
- Added error handling.

Changes v8->v9:
- Rebased to v6.7rc4.
- Updated the bindings format.
- Dropped removed() interface.

Changes v7->v8:
- Rebased to v6.7rc3.
- Changed compatible to "opencores,pwm-v1"
- Adjusted the clock unprepare order.
- Followed dt-bindings Coding style.

Changes v6->v7:
- Rebased to v6.6.
- Added dependency architecture.
- Adopted new rounding algorithm.
- Added limitation descripton.
- Used function interfaces instead of macro definitions.
- Followed the linux coding style.

Changes v5->v6:
- Rebased to v6.6rc5.
- Changed driver into a generic OpenCores driver.
- Modified dt-bindings description into OpenCores.
- Uesd the StarFive compatible string to parameterize.

Changes v4->v5:
- Rebased to v6.6rc2.
- Updated macro definition indent.
- Replaced the clock initializes the interface.
- Fixed patch description.

Changes v3->v4:
- Rebased to v6.5rc7.
- Sorted the header files in alphabetic order.
- Changed iowrite32() to writel().
- Added a way to turn off.
- Modified polarity inversion implementation.
- Added 7100 support.
- Added dts patches.
- Used the various helpers in linux/math.h.
- Corrected formatting problems.
- Renamed dtbinding to 'starfive,jh7100-pwm.yaml'.
- Dropped the redundant code.

Changes v2->v3:
- Fixed some formatting issues.

Changes v1->v2:
- Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'.
- Dropped the compatible's Items.
- Dropped the unuse defines.
- Modified the code to follow the Linux coding style.
- Changed return value to dev_err_probe.
- Dropped the unnecessary local variable.

The patch series is based on v6.7rc6.

William Qiu (4):
dt-bindings: pwm: Add bindings for OpenCores PWM Controller
pwm: opencores: Add PWM driver support
riscv: dts: starfive: jh7100: Add PWM node and pins configuration
riscv: dts: starfive: jh7110: Add PWM node and pins configuration

 .../bindings/pwm/opencores,pwm.yaml           |  55 +++++
 MAINTAINERS                                   |   7 +
 .../boot/dts/starfive/jh7100-common.dtsi      |  24 ++
 arch/riscv/boot/dts/starfive/jh7100.dtsi      |   9 +
 .../jh7110-starfive-visionfive-2.dtsi         |  22 ++
 arch/riscv/boot/dts/starfive/jh7110.dtsi      |   9 +
 drivers/pwm/Kconfig                           |  12 +
 drivers/pwm/Makefile                          |   1 +
 drivers/pwm/pwm-ocores.c                      | 233 ++++++++++++++++++
 9 files changed, 372 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
 create mode 100644 drivers/pwm/pwm-ocores.c

--
2.34.1