Skip to content

serial: core: fix broken console after suspend

Lukasz Majczak linux-serial lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v11 patch 6 repliesSuperseded

Changes in v2 from the cover letter

* Fixed typos in commit message
* Tested[2] patch "serial: core: preserve cflags, ispeed and ospeed" on all current LTS kernels (4.14, 4.19, 5.4, 5.10, 5.15, 6.1) and on top of 6.3-rc5 with positive results - console was working after resume
* During tests another issue was observed on 6.1+ - FIFO not enabled after resume - and an additional change was needed ("serial: core: enable FIFO after resume")
* Test procedure:
1) ensure the console output is ok
2) suspend device with "echo freeze > /sys/power/state"

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2serial: core: preserve cflags, ispeed and ospeeddrivers/tty/serial/serial_core.c+0 -30 replies
2/2serial: core: enable FIFO after resumedrivers/tty/serial/serial_core.c+27 -271 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] serial: core: fix broken console after suspend

This is v2 of a patch[1].
v1->v2:
* Fixed typos in commit message
* Tested[2] patch "serial: core: preserve cflags, ispeed and ospeed" on all current LTS kernels (4.14, 4.19, 5.4, 5.10, 5.15, 6.1) and on top of 6.3-rc5 with positive results - console was working after resume
* During tests another issue was observed on 6.1+ - FIFO not enabled after resume - and an additional change was needed ("serial: core: enable FIFO after resume")
* Test procedure:
1) ensure the console output is ok
2) suspend device with "echo freeze > /sys/power/state"

     (/sys/module/printk/parameters/console_suspend == N)
  3) resume device and check the console output
  4) suspend device with "echo freeze > /sys/power/state"
     (/sys/module/printk/parameters/console_suspend == Y)

5) resume device and check the console output

[1] https://lore.kernel.org/lkml/[email protected]/
[2] Test platforms: PC with i5-8400 + GB H370M D3H
HP Elite c1030 Chromebook Enterprise i5-10310U

Lukasz Majczak (2):
serial: core: preserve cflags, ispeed and ospeed
serial: core: enable FIFO after resume

 drivers/tty/serial/serial_core.c | 57 +++++++++++++++-----------------
 1 file changed, 27 insertions(+), 30 deletions(-)
Signature · 1 line
2.40.0.577.gac1e443424-goog