Skip to content

RFC Unifying fabrics drivers

Daniel Wagner linux-nvme lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest9 patches 3 repliesIn review
  2. v2 RFC6 patches 0 repliesSuperseded
  3. v1 RFC3 patches 13 repliesSuperseded

v2 from the cover letter

- move the complete ctrl state machine to fabrics.c
- https://lore.kernel.org/linux-nvme/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9nvme-rdma: stream line queue functions argumentsdrivers/nvme/host/rdma.c+40 -220 replies
2/9nvme-rdma: factor rdma specific queue init code outdrivers/nvme/host/rdma.c+46 -190 replies
3/9nvme-tcp: move error and connect work to nvme_ctrldrivers/nvme/host/nvme.h drivers/nvme/host/tcp.c+13 -140 replies
4/9nvme-rdma: use error and connect work from nvme_ctrldrivers/nvme/host/rdma.c+12 -130 replies
5/9nvme-fabrics: add fabric state machinedrivers/nvme/host/fabrics.c drivers/nvme/host/fabrics.h drivers/nvme/host/nvme.h+454 -00 replies
6/9nvme-tcp: replace state machine with generic onedrivers/nvme/host/tcp.c+175 -5230 replies
7/9nvme-rdma: replace state machine with generic onedrivers/nvme/host/rdma.c+173 -5300 replies
8/9nvme: move queue flags to middle layerdrivers/nvme/host/fabrics.c drivers/nvme/host/nvme.h drivers/nvme/host/rdma.c +1 more+197 -1411 reply
9/9nvme: introduce setup_transport()drivers/nvme/host/fabrics.c drivers/nvme/host/fabrics.h drivers/nvme/host/rdma.c +1 more+59 -631 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [RFC v3 0/9] Unifying fabrics drivers

I've rebased on nvme-6.4 and gave it a bit of testing. Up to the last patch it seems to work fine, at least blktests doesn't trigger any errors.

I've tried to split the pure moving code around part from the part where we need to change some code. That means the last two patches highlight the problems I run into with this attempt to implement the setup_transport() callback

changes:
v2:
- move the complete ctrl state machine to fabrics.c
- https://lore.kernel.org/linux-nvme/[email protected]/

v1:
- https://lore.kernel.org/linux-nvme/[email protected]/

Daniel Wagner (9):
nvme-rdma: stream line queue functions arguments
nvme-rdma: factor rdma specific queue init code out
nvme-tcp: move error and connect work to nvme_ctrl
nvme-rdma: use error and connect work from nvme_ctrl
nvme-fabrics: add fabric state machine
nvme-tcp: replace state machine with generic one
nvme-rdma: replace state machine with generic one
nvme: move queue flags to middle layer
nvme: introduce setup_transport()

 drivers/nvme/host/fabrics.c | 513 +++++++++++++++++++++++++
 drivers/nvme/host/fabrics.h |  24 ++
 drivers/nvme/host/nvme.h    |  19 +
 drivers/nvme/host/rdma.c    | 720 ++++++++++--------------------------
 drivers/nvme/host/tcp.c     | 706 ++++++++---------------------------
 5 files changed, 913 insertions(+), 1069 deletions(-)
Signature · 1 line
2.40.0