Skip to content

Migration: Make more ram_counters atomic

Juan Quintela qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 3 repliesIn review
  2. v52 patches 4 repliesSuperseded
  3. v42 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v312 patches2 repliesSuperseded
v23 patches1 replySuperseded
v13 patches3 repliesSuperseded

Changes in v6 from the cover letter

- Create stat64_set() operation
Impersonating Paolo in "Author" field, as he is the real author.
- Update to stat64_set()
- Everything is consistent and coherent under the sun.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3stat64: Add stat64_set() operationinclude/qemu/stats64.h util/stats64.c+17 -01 reply
2/3migration: Make dirty_pages_rate atomicmigration/migration.c migration/ram.c migration/ram.h+8 -51 reply
3/3migration: Make dirty_bytes_last_sync atomicmigration/migration.c migration/ram.c migration/ram.h+4 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPeter XuJuan QuintelaRichard Henderson
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] Migration: Make more ram_counters atomic

Hi

Changes in v6:
- Create stat64_set() operation
Impersonating Paolo in "Author" field, as he is the real author.
- Update to stat64_set()
- Everything is consistent and coherent under the sun.

Please review.

[v5]
Not only change the type of the counters, also use the __nocheck() variants of the functions.

Please, review.

[v4]
- Change aligned_uint64_t to size_t to make (some) 32bit hosts happy.

Please review.

[v3]
- Addressed reviews
- All counters are now atomic, either Stat64 or atomic.
- Rename duplicated to zero_pages
- Rename normal to zero_pages.

Please review.

[v2]
- fix typos found by David Edmondson
- Add review-by tags.

Please review.

[v1]
On previous series we cerate ram_atomic_counters. But we basically need that all counters are atomic. So move back to only have ram_counters, just with a new type that allows the atomic counters.

Once there, move update of stats out of RAM mutex. And make multifd_bytes atomic.

Later, Juan.

Juan Quintela (2):
migration: Make dirty_pages_rate atomic
migration: Make dirty_bytes_last_sync atomic

Paolo Bonzini (1):
stat64: Add stat64_set() operation

 include/qemu/stats64.h |  6 ++++++
 migration/migration.c  |  9 ++++++---
 migration/ram.c        |  7 ++++---
 migration/ram.h        |  4 ++--
 util/stats64.c         | 11 +++++++++++
 5 files changed, 29 insertions(+), 8 deletions(-)
Signature · 1 line
2.40.0