Skip to content

Migration: Create options.c for capabilities/params/properties

Juan Quintela qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 17 repliesIn review
  2. v243 patches 21 repliesSuperseded
  3. v143 patches 18 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13migration: Move migrate_use_tls() to options.cmigration/migration.c migration/migration.h migration/options.c +2 more+13 -131 reply
2/13migration: Move qmp_migrate_set_parameters() to options.cmigration/migration.c migration/options.c migration/options.h+429 -4201 reply
3/13migration: Create migrate_params_init() functionmigration/migration.c migration/options.c migration/options.h+33 -281 reply
4/13migration: Make all functions check have the same formatmigration/options.c+39 -1141 reply
5/13migration: Create migrate_downtime_limit() functionmigration/migration.c migration/options.c migration/options.h+10 -21 reply
6/13migration: Move migrate_set_block_incremental() to options.cmigration/migration.c migration/options.c migration/options.h+15 -73 replies
7/13migration: Move block_cleanup_parameters() to options.cmigration/migration.c migration/options.c migration/options.h+11 -101 reply
8/13migration: Remove MigrationState from block_cleanup_parameters()migration/migration.c migration/options.c migration/options.h+6 -42 replies
9/13migration: Create migrate_tls_creds() functionmigration/options.c migration/options.h migration/tls.c+12 -52 replies
10/13migration: Create migrate_tls_authz() functionmigration/options.c migration/options.h migration/tls.c+9 -41 reply
11/13migration: Create migrate_tls_hostname() functionmigration/options.c migration/options.h migration/tls.c+12 -21 reply
12/13migration: Create migrate_block_bitmap_mapping() functionmigration/block-dirty-bitmap.c migration/options.c migration/options.h+16 -61 reply
13/13migration: Move migration_properties to options.cmigration/migration.c migration/options.c migration/options.h+162 -1571 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-Ogievskiy
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/13] Migration: Create options.c for capabilities/params/properties

Hi

In this v3:
- Rebase on top of latest.
- Fix review of migrate_use_tls() comments.
- Remaining of the patches not yet reviewed.

Please review.

[v2]
- the first two patches are included on the last pull request.
- Changed copyright from Anthony to Orit (thanks David) Some archeology required.
- Get all the reviews by from Vladimir.
- Rebased on top of my last pull request.

The first two patches don't belong in this series, but without them I got lots of confilcts if you try to use the series. That two patches are independently on the list.

Please review.

[v1]
This series move to options.c:
- all migration capabilities code
- all migration parameters code
- all properties code
- all qmp commands that only touch the previous

And once there:
- sort of functions
- make consistent and coherent all the functions naming/typing
- create accessors for the parameters/capabilties that don't exist
- more cleanups here and there.

Todo:

- There is still capabilities code on savevm.c, but I want this in before moving that code to options.c, but still needs more thought for my part. I.e. should I put vmstate sections in options.c, or should I create new functions to access the capabilities in savevm.c.

Please review.

Juan Quintela (13):
migration: Move migrate_use_tls() to options.c
migration: Move qmp_migrate_set_parameters() to options.c
migration: Create migrate_params_init() function
migration: Make all functions check have the same format
migration: Create migrate_downtime_limit() function
migration: Move migrate_set_block_incremental() to options.c
migration: Move block_cleanup_parameters() to options.c
migration: Remove MigrationState from block_cleanup_parameters()
migration: Create migrate_tls_creds() function
migration: Create migrate_tls_authz() function
migration: Create migrate_tls_hostname() function
migration: Create migrate_block_bitmap_mapping() function
migration: Move migration_properties to options.c

 migration/block-dirty-bitmap.c |  14 +-
 migration/migration.c          | 640 +-------------------------
 migration/migration.h          |   2 -
 migration/options.c            | 818 ++++++++++++++++++++++++++++-----
 migration/options.h            |  30 ++
 migration/tls.c                |  23 +-
 6 files changed, 761 insertions(+), 766 deletions(-)
Signature · 1 line
2.39.2