Migration: Create options.c for capabilities/params/properties
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest13 patches 17 repliesIn review
- v243 patches 21 repliesSuperseded
- v143 patches 18 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | migration: Move migrate_use_tls() to options.cmigration/ migration/ migration/ +2 more | +13 | 1 reply | |
| 2/13 | migration: Move qmp_migrate_set_parameters() to options.cmigration/ migration/ migration/ | +429 | 1 reply | |
| 3/13 | migration: Create migrate_params_init() functionmigration/ migration/ migration/ | +33 | 1 reply | |
| 4/13 | migration: Make all functions check have the same formatmigration/ | +39 | 1 reply | |
| 5/13 | migration: Create migrate_downtime_limit() functionmigration/ migration/ migration/ | +10 | 1 reply | |
| 6/13 | migration: Move migrate_set_block_incremental() to options.cmigration/ migration/ migration/ | +15 | 3 replies | |
| 7/13 | migration: Move block_cleanup_parameters() to options.cmigration/ migration/ migration/ | +11 | 1 reply | |
| 8/13 | migration: Remove MigrationState from block_cleanup_parameters()migration/ migration/ migration/ | +6 | 2 replies | |
| 9/13 | migration: Create migrate_tls_creds() functionmigration/ migration/ migration/ | +12 | 2 replies | |
| 10/13 | migration: Create migrate_tls_authz() functionmigration/ migration/ migration/ | +9 | 1 reply | |
| 11/13 | migration: Create migrate_tls_hostname() functionmigration/ migration/ migration/ | +12 | 1 reply | |
| 12/13 | migration: Create migrate_block_bitmap_mapping() functionmigration/ migration/ migration/ | +16 | 1 reply | |
| 13/13 | migration: Move migration_properties to options.cmigration/ migration/ migration/ | +162 | 1 reply |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| 1/13 | R-b |
| 2/13 | R-b |
| 3/13 | R-b |
| 4/13 | R-b |
| 5/13 | R-b |
| 6/13 | R-b |
| 7/13 | R-b |
| 8/13 | R-b |
| 9/13 | R-b |
| 10/13 | R-b |
| 11/13 | R-b |
| 12/13 | R-b |
| 13/13 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/13] Migration: Create options.c for capabilities/params/properties
Hi
In this v3:
- Rebase on top of latest.
- Fix review of migrate_use_tls() comments.
- Remaining of the patches not yet reviewed.
Please review.
[v2]
- the first two patches are included on the last pull request.
- Changed copyright from Anthony to Orit (thanks David) Some archeology required.
- Get all the reviews by from Vladimir.
- Rebased on top of my last pull request.
The first two patches don't belong in this series, but without them I got lots of confilcts if you try to use the series. That two patches are independently on the list.
Please review.
[v1]
This series move to options.c:
- all migration capabilities code
- all migration parameters code
- all properties code
- all qmp commands that only touch the previous
And once there:
- sort of functions
- make consistent and coherent all the functions naming/typing
- create accessors for the parameters/capabilties that don't exist
- more cleanups here and there.
Todo:
- There is still capabilities code on savevm.c, but I want this in before moving that code to options.c, but still needs more thought for my part. I.e. should I put vmstate sections in options.c, or should I create new functions to access the capabilities in savevm.c.
Please review.
Juan Quintela (13):
migration: Move migrate_use_tls() to options.c
migration: Move qmp_migrate_set_parameters() to options.c
migration: Create migrate_params_init() function
migration: Make all functions check have the same format
migration: Create migrate_downtime_limit() function
migration: Move migrate_set_block_incremental() to options.c
migration: Move block_cleanup_parameters() to options.c
migration: Remove MigrationState from block_cleanup_parameters()
migration: Create migrate_tls_creds() function
migration: Create migrate_tls_authz() function
migration: Create migrate_tls_hostname() function
migration: Create migrate_block_bitmap_mapping() function
migration: Move migration_properties to options.c
migration/block-dirty-bitmap.c | 14 +- migration/migration.c | 640 +------------------------- migration/migration.h | 2 - migration/options.c | 818 ++++++++++++++++++++++++++++----- migration/options.h | 30 ++ migration/tls.c | 23 +- 6 files changed, 761 insertions(+), 766 deletions(-)
Signature · 1 line
2.39.2