drm/msm: fix bind error handling
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"drivers/ | +0 | 1 reply | |
| 2/10 | Revert "drm/msm: Fix failure paths in msm_drm_init()"drivers/ drivers/ | +4 | 1 reply | |
| 3/10 | drm/msm: fix NULL-deref on snapshot tear downdrivers/ | +2 | 1 reply | |
| 4/10 | drm/msm: fix NULL-deref on irq uninstalldrivers/ | +5 | 1 reply | |
| 5/10 | drm/msm: fix drm device leak on bind errorsdrivers/ | +8 | 3 replies | |
| 6/10 | drm/msm: fix vram leak on bind errorsdrivers/ | +19 | 1 reply | |
| 7/10 | drm/msm: fix missing wq allocation error handlingdrivers/ | +4 | 1 reply | |
| 8/10 | drm/msm: fix workqueue leak on bind errorsdrivers/ | +4 | 1 reply | |
| 9/10 | drm/msm: use drmm_mode_config_init()drivers/ | +5 | 2 replies | |
| 10/10 | drm/msm: move include directivedrivers/ | +1 | 1 reply |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Dmitry Baryshkov |
|---|---|
| 1/10 | R-b |
| 2/10 | R-b |
| 3/10 | R-b |
| 4/10 | R-b |
| 5/10 | R-b |
| 6/10 | R-b |
| 7/10 | R-b |
| 8/10 | R-b |
| 9/10 | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] drm/msm: fix bind error handling
I had reasons to look closer at the MSM DRM driver error handling and realised that it had suffered from a fair amount of bit rot over the years.
Unfortunately, I started fixing this in my 6.2 branch and failed to notice two partial and, as it turned out, broken attempts to address this that are now in 6.3-rc1.
Instead of trying to salvage this incrementally, I'm reverting the two broken commits so that clean and backportable fixes can be added in their place.
Included are also two related cleanups.
Johan
Johan Hovold (10):
Revert "drm/msm: Add missing check and destroy for
alloc_ordered_workqueue"
Revert "drm/msm: Fix failure paths in msm_drm_init()" drm/msm: fix NULL-deref on snapshot tear down drm/msm: fix NULL-deref on irq uninstall drm/msm: fix drm device leak on bind errors drm/msm: fix vram leak on bind errors drm/msm: fix missing wq allocation error handling drm/msm: fix workqueue leak on bind errors drm/msm: use drmm_mode_config_init() drm/msm: move include directive
drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 3 - drivers/gpu/drm/msm/msm_drv.c | 67 +++++++++++++------- 2 files changed, 44 insertions(+), 26 deletions(-)
Signature · 1 line
2.39.2