Skip to content

mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes

Yue Zhao cgroups linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit v2:
- Rephrase changelog
- Add [WRITE|READ]_ONCE for memcg->oom_kill_disable, memcg->swappiness, vm_swappiness and memcg->soft_limit

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mm, memcg: Prevent memory.oom.group load/store tearingmm/memcontrol.c+3 -30 replies
2/4mm, memcg: Prevent memory.swappiness load/store tearinginclude/linux/swap.h mm/memcontrol.c+7 -70 replies
3/4mm, memcg: Prevent memory.oom_control load/store tearingmm/memcontrol.c+5 -50 replies
4/4mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearingmm/memcontrol.c+4 -40 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichal HockoShakeel Butt
SeriesA-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes

This patch series helps to prevent load/store tearing in several cgroup knobs.

As kindly pointed out by Michal Hocko, we should add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit.

v3:
- Add [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit v2:
- Rephrase changelog
- Add [WRITE|READ]_ONCE for memcg->oom_kill_disable, memcg->swappiness, vm_swappiness and memcg->soft_limit
v1:
- Add [WRITE|READ]_ONCE for memcg->oom_group

Past patches:
V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org/
V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org/

Yue Zhao (4):
mm, memcg: Prevent memory.oom.group load/store tearing mm, memcg: Prevent memory.swappiness load/store tearing mm, memcg: Prevent memory.oom_control load/store tearing mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing

 include/linux/swap.h |  8 ++++----
 mm/memcontrol.c      | 30 +++++++++++++++---------------
 2 files changed, 19 insertions(+), 19 deletions(-)
Signature · 1 line
2.17.1