Skip to content

Add DT support for generic ADC battery

Sebastian Reichel linux-devicetree linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 6 repliesIn review
  2. v212 patches 13 repliesSuperseded
  3. v111 patches 25 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14dt-bindings: power: supply: adc-battery: add bindingDocumentation/devicetree/bindings/power/supply/adc-battery.yaml+70 -00 replies
2/14power: supply: core: auto-exposure of simple-battery datadrivers/power/supply/power_supply_core.c drivers/power/supply/power_supply_sysfs.c include/linux/power_supply.h+191 -193 replies
3/14power: supply: generic-adc-battery: convert to managed resourcesdrivers/power/supply/generic-adc-battery.c+23 -580 replies
4/14power: supply: generic-adc-battery: fix unit scalingdrivers/power/supply/generic-adc-battery.c+3 -00 replies
5/14power: supply: generic-adc-battery: drop jitter delay supportdrivers/power/supply/generic-adc-battery.c include/linux/power/generic-adc-battery.h+4 -120 replies
6/14power: supply: generic-adc-battery: drop charge now supportdrivers/power/supply/generic-adc-battery.c include/linux/power/generic-adc-battery.h+0 -60 replies
7/14power: supply: generic-adc-battery: drop memory alloc error messagedrivers/power/supply/generic-adc-battery.c+1 -30 replies
8/14power: supply: generic-adc-battery: use simple-battery APIdrivers/power/supply/generic-adc-battery.c include/linux/power/generic-adc-battery.h+4 -781 reply
9/14power: supply: generic-adc-battery: simplify read_channel logicdrivers/power/supply/generic-adc-battery.c+5 -260 replies
10/14power: supply: generic-adc-battery: add temperature supportdrivers/power/supply/generic-adc-battery.c+6 -10 replies
11/14power: supply: generic-adc-battery: add DT supportdrivers/power/supply/generic-adc-battery.c+9 -00 replies
12/14power: supply: generic-adc-battery: update copyright infodrivers/power/supply/generic-adc-battery.c+3 -80 replies
13/14power: supply: generic-adc-battery: improve error messagedrivers/power/supply/generic-adc-battery.c+1 -12 replies
14/14power: supply: generic-adc-battery: style fixesdrivers/power/supply/generic-adc-battery.c+10 -160 replies

Reviews trailers per patch

13 of 14 patches have a Reviewed-by or Acked-by.

PatchMatti VaittinenKrzysztof KozlowskiLinus Walleij
1/14R-b R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b R-b
11/14R-b R-b
12/14R-b R-b
13/14R-b R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCHv3 00/14] Add DT support for generic ADC battery

Hi,

This series cleans up the generic ADC battery driver and adds devicetree support. The plan is to use the driver to add upstream support for a handheld thermal camera.

Instead of reading and exposing the monitored battery data manually I started the series with an addition to the power-supply core, which allows automatic handling of the static battery information. It simplifies the generic-adc-battery driver a lot and should also be useful for other battery drivers.

Changes since PATCHv2:
* collect more Reviewed-by (again skipped PATCH 1)
* updated battery-info auto-exposure to only do it for TYPE_BATTERY power-supply devices.
* Fix battery-info auto-exposure to avoid duplicated uevent variables
* Added two more cleanup patches at the end of the series

Changes since PATCHv1:
* collect Reviewed-by
(I did not collect them for the auto-exposure because of the code changes)
* always auto expose battery data (without opt-in)
* update DT binding according to feedback
* add temperature support
* fix issues pointed out by the Intel build bot
- move power_supply_battery_info_properties to power_supply_core.c
- restore accidently removed EXPORT_SYMBOL for power_supply_get_property

-- Sebastian

Sebastian Reichel (14):
dt-bindings: power: supply: adc-battery: add binding
power: supply: core: auto-exposure of simple-battery data
power: supply: generic-adc-battery: convert to managed resources
power: supply: generic-adc-battery: fix unit scaling
power: supply: generic-adc-battery: drop jitter delay support
power: supply: generic-adc-battery: drop charge now support
power: supply: generic-adc-battery: drop memory alloc error message
power: supply: generic-adc-battery: use simple-battery API
power: supply: generic-adc-battery: simplify read_channel logic
power: supply: generic-adc-battery: add temperature support
power: supply: generic-adc-battery: add DT support
power: supply: generic-adc-battery: update copyright info
power: supply: generic-adc-battery: improve error message
power: supply: generic-adc-battery: style fixes

 .../bindings/power/supply/adc-battery.yaml    |  70 +++++
 drivers/power/supply/generic-adc-battery.c    | 245 +++++-------------
 drivers/power/supply/power_supply_core.c      | 179 +++++++++++--
 drivers/power/supply/power_supply_sysfs.c     |  23 +-
 include/linux/power/generic-adc-battery.h     |  23 --
 include/linux/power_supply.h                  |   8 +
 6 files changed, 325 insertions(+), 223 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/supply/adc-battery.yaml
 delete mode 100644 include/linux/power/generic-adc-battery.h
Signature · 1 line
2.39.2