telemetry: remove variable length arrays
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 8 repliesApplied
- v25 patches 2 repliesSuperseded
- v11 patch 2 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | telemetry: fix autotest failures on Alpinelib/ | +18 | 1 reply | |
| 2/5 | telemetry: remove variable length array in printf fnlib/ | +32 | 1 reply | |
| 3/5 | telemetry: split out body of json string format fnlib/ | +24 | 1 reply | |
| 4/5 | telemetry: rename local variableslib/ | +16 | 2 replies | |
| 5/5 | telemetry: remove VLA in json string format functionapp/ lib/ | +18 | 2 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Tyler Retzlaff |
|---|---|
| 1/5 | A-b |
| 2/5 | A-b |
| 3/5 | A-b |
| 4/5 | A-b |
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/5] telemetry: remove variable length arrays
This patchset introduces a series of changes to remove variable-length arrays from the telemetry code. The first patch replaces a VLA with malloc memory for the serialization of the json objects contained within the main response object, which fixes a crash observed on alpine linux.
Subsequent patches rework the json printing code to avoid the use of temporary buffers where possible, or use malloc-allocated memory where not.
Based off testing with the unit tests for telemetry, json serialization for the telemetry callbacks should always use the path where a temporary buffer is *not* used, but the allocation-case is kept to ensure that any unexpected edge-cases are covered too.
V3: remove use of non-standard asprintf function in patch 2.
V2: expand from single fix for Alpine, to general cleanup to remove VLAs
Bruce Richardson (5):
telemetry: fix autotest failures on Alpine
telemetry: remove variable length array in printf fn
telemetry: split out body of json string format fn
telemetry: rename local variables
telemetry: remove VLA in json string format function
app/test/test_telemetry_json.c | 2 +- lib/telemetry/telemetry.c | 21 ++++++- lib/telemetry/telemetry_json.h | 111 +++++++++++++++++++++++++-------- 3 files changed, 104 insertions(+), 30 deletions(-)
--
2.37.2