Skip to content

interconnect: qcom: rpm: fix msm8996 interconnect registration

Johan Hovold linux-arm-msm linux-pm lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2interconnect: qcom: rpm: fix msm8996 interconnect registrationdrivers/interconnect/qcom/icc-rpm.c+2 -12 replies
2/2interconnect: qcom: rpm: drop bogus pm domain attachdrivers/interconnect/qcom/icc-rpm.c drivers/interconnect/qcom/icc-rpm.h drivers/interconnect/qcom/msm8996.c+0 -83 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKonrad Dybcio
1/2R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration

Christophe noticed that a recent patch adding a missing clock disable to one of the Qualcomm rpm driver error paths was broken. This would lead to the provider not being registered on msm8996 which is the only platform using this code path.

Turns out, however, that the power domain attach during probe is bogus and would always succeed as any power domain would already have been attached by the platform bus code.

Georgi, the offending commit is currently in your icc-next (and local icc-fixes) branch. Perhaps you can fold in the fixup unless you prefer applying it on top.

The bogus PM domain lookup is redundant and confusing but should otherwise be benign so the removal could be applied to either branch.

Johan

Johan Hovold (2):
interconnect: qcom: rpm: fix msm8996 interconnect registration
interconnect: qcom: rpm: drop bogus pm domain attach

 drivers/interconnect/qcom/icc-rpm.c | 5 -----
 drivers/interconnect/qcom/icc-rpm.h | 1 -
 drivers/interconnect/qcom/msm8996.c | 1 -
 3 files changed, 7 deletions(-)
Signature · 1 line
2.39.2