Skip to content

cros-ec-tests: fix some exceptions and clean-ups

Tzung-Bi Shih chrome-platform 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14lava_runner: rename to LavaTestResultcros/runners/lava_runner.py+2 -20 replies
2/14lava_runner: use TextTestRunnercros/runners/lava_runner.py+7 -220 replies
3/14lava_runner: use TextTestResultcros/runners/lava_runner.py+20 -240 replies
4/14lava_runner: respect to verbosity flag from unittest frameworkcros/runners/lava_runner.py+8 -10 replies
5/14helpers/sysfs: fix NameErrorcros/helpers/sysfs.py+1 -10 replies
6/14helpers/mcu: fix ResourceWarning on /dev/cros_eccros/helpers/mcu.py+2 -50 replies
7/14cros_ec_pwm: fix ResourceWarning on /sys/kernel/debug/pwmcros/tests/cros_ec_pwm.py+11 -130 replies
8/14treewide: use context manager on file objectscros/helpers/kernel.py cros/helpers/mcu.py cros/helpers/sysfs.py +3 more+20 -320 replies
9/14cros_ec_pwm: use RE to search EC backlight PWMcros/tests/cros_ec_pwm.py+7 -170 replies
10/14helpers/mcu: fix packet too long errorcros/helpers/mcu.py+2 -20 replies
11/14helpers/mcu: fix EC_CMD_GET_FEATURES usagecros/helpers/mcu.py+5 -110 replies
12/14treewide: remove "r" in open() if reading modecros/helpers/kernel.py cros/helpers/mcu.py cros/helpers/sysfs.py +4 more+13 -130 replies
13/14treewide: don't use "+" operator for constructing pathscros/helpers/mcu.py cros/helpers/sysfs.py cros/tests/cros_ec_accel.py +2 more+30 -210 replies
14/14treewide: don't use "+" operator for concatenating stringscros/helpers/mcu.py cros/tests/cros_ec_accel.py+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] cros-ec-tests: fix some exceptions and clean-ups

The series changes cros-ec-tests[1].

It applys some clean-ups and fixes obvious errors.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/

Tzung-Bi Shih (14):
lava_runner: rename to LavaTestResult
lava_runner: use TextTestRunner
lava_runner: use TextTestResult
lava_runner: respect to verbosity flag from unittest framework helpers/sysfs: fix NameError
helpers/mcu: fix ResourceWarning on /dev/cros_ec
cros_ec_pwm: fix ResourceWarning on /sys/kernel/debug/pwm
treewide: use context manager on file objects
cros_ec_pwm: use RE to search EC backlight PWM helpers/mcu: fix packet too long error
helpers/mcu: fix EC_CMD_GET_FEATURES usage
treewide: remove "r" in open() if reading mode
treewide: don't use "+" operator for constructing paths
treewide: don't use "+" operator for concatenating strings

 cros/helpers/kernel.py       |  5 ++-
 cros/helpers/mcu.py          | 57 ++++++++++++++------------------
 cros/helpers/sysfs.py        | 16 ++++-----
 cros/runners/lava_runner.py  | 64 +++++++++++++++---------------------
 cros/tests/cros_ec_accel.py  | 13 ++++----
 cros/tests/cros_ec_extcon.py | 11 ++++---
 cros/tests/cros_ec_pwm.py    | 58 +++++++++++++-------------------
 cros/tests/cros_ec_rtc.py    |  8 ++---
 setup.py                     |  2 +-
 9 files changed, 99 insertions(+), 135 deletions(-)
Signature · 1 line
2.40.0.rc1.284.g88254d51c5-goog