Cpu page-table updates and fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 3 repliesIn review
- v16 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- Use __dma_fence_is_later() to compare fence seqnos.
- Add Patch drm/xe/vm: Defer vm rebind until next exec if nothing to execute
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | drm/xe: Use a define to set initial seqno for fencesdrivers/ drivers/ drivers/ +1 more | +10 | 2 replies | |
| 2/7 | drm/xe/migrate: Update cpu page-table updatesdrivers/ | +10 | 0 replies | |
| 3/7 | drm/xe/tests: Support CPU page-table updates in the migrate testdrivers/ | +10 | 0 replies | |
| 4/7 | drm/xe: Introduce xe_engine_is_idle()drivers/ drivers/ drivers/ | +26 | 0 replies | |
| 5/7 | drm/xe: Use a small negative initial seqnodrivers/ | +2 | 0 replies | |
| 6/7 | drm/xe/tests: Test both CPU- and GPU page-table updates with the migrate testdrivers/ drivers/ drivers/ | +40 | 0 replies | |
| 7/7 | drm/xe/vm: Defer vm rebind until next exec if nothing to executedrivers/ drivers/ drivers/ +1 more | +41 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Auld | Matthew Brost |
|---|---|---|
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-xe] [PATCH v2 0/7] Cpu page-table updates and fixes
There were flaws in the engine idle computation used to determine whether we could use CPU page-table updates. Fix those
It also turns out fixing those triggers CPU-page-table updates in the migrate test, which didn't really support that, so also fix the migrate test to handle that and to run the test twice, once with CPU- and once with GPU page-table updates, and to also provide some timings for non-synced updates. (The timings avoid the GPU submission latency to better reflect the case where we are able to pipeline GPU page-table updates).
Provide some coverage for the fence seqno 32-bit wrapping case by setting the initial fence seqno to a small negative number.
Finally use the new xe_engine_is_idle() function to fix the memory ping-ponging issue that can be triggered by the xe_noexec_ping_pong igt currently on review.
v2:
- Use __dma_fence_is_later() to compare fence seqnos.
- Add Patch drm/xe/vm: Defer vm rebind until next exec if nothing to execute
Thomas Hellström (7):
drm/xe: Use a define to set initial seqno for fences drm/xe/migrate: Update cpu page-table updates drm/xe/tests: Support CPU page-table updates in the migrate test drm/xe: Introduce xe_engine_is_idle()
drm/xe: Use a small negative initial seqno drm/xe/tests: Test both CPU- and GPU page-table updates with the
migrate test
drm/xe/vm: Defer vm rebind until next exec if nothing to execute
drivers/gpu/drm/xe/tests/xe_migrate.c | 35 +++++++++++++++-- drivers/gpu/drm/xe/tests/xe_test.h | 1 + drivers/gpu/drm/xe/xe_engine.c | 28 +++++++++++++- drivers/gpu/drm/xe/xe_engine.h | 2 + drivers/gpu/drm/xe/xe_exec.c | 1 + drivers/gpu/drm/xe/xe_hw_fence.c | 4 +- drivers/gpu/drm/xe/xe_hw_fence.h | 3 ++ drivers/gpu/drm/xe/xe_lrc.c | 3 ++ drivers/gpu/drm/xe/xe_migrate.c | 55 ++++++++++++++------------- drivers/gpu/drm/xe/xe_vm.c | 18 +++++++++ drivers/gpu/drm/xe/xe_vm.h | 17 +++++++++ drivers/gpu/drm/xe/xe_vm_types.h | 5 +++ 12 files changed, 137 insertions(+), 35 deletions(-)
Signature · 1 line
2.39.2