Skip to content

can: tcan4x5x: Introduce tcan4552/4553

Markus Schneider-Pargmann linux-can linux-devicetree lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 3 repliesIn review
  2. v36 patches 4 repliesSuperseded
  3. v26 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches14 repliesSuperseded

Changes in v4 from the cover letter

- Use printk("... %pe\n", ERR_PTR(ret)) for new printks

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variantsDocumentation/devicetree/bindings/net/can/tcan4x5x.txt+8 -31 reply
2/6can: tcan4x5x: Remove reserved register 0x814 from writable tabledrivers/net/can/m_can/tcan4x5x-regmap.c+0 -10 replies
3/6can: tcan4x5x: Check size of mram configurationdrivers/net/can/m_can/m_can.c drivers/net/can/m_can/m_can.h drivers/net/can/m_can/tcan4x5x-core.c+22 -00 replies
4/6can: tcan4x5x: Rename ID registers to match datasheetdrivers/net/can/m_can/tcan4x5x-core.c+2 -20 replies
5/6can: tcan4x5x: Add support for tcan4552/4553drivers/net/can/m_can/tcan4x5x-core.c+90 -140 replies
6/6can: tcan4x5x: Add error messages in probedrivers/net/can/m_can/tcan4x5x-core.c+23 -60 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiMichal KubiakRob Herring
1/6A-b R-b
2/6R-b
3/6R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/6] can: tcan4x5x: Introduce tcan4552/4553

Hi everyone,

This series introduces two new chips tcan-4552 and tcan-4553. The generic driver works in general but needs a few small changes. These are caused by the removal of wake and state pins.

v4 updates the printks to use '%pe'.

Based on v6.5-rc1.

Best,
Markus

Changes in v4:
- Use printk("... %pe\n", ERR_PTR(ret)) for new printks

Changes in v3:
- Rebased to v6.5-rc1
- Removed devicetree compatible check in tcan driver. The device version is now unconditionally detected using the ID2 register

Changes in v2:
- Update the binding documentation to specify tcan4552 and tcan4553 with the tcan4x5x as fallback
- Update the driver to use auto detection as well. If compatible differs from the ID2 register, use the ID2 register and print a warning.
- Small style changes

Previous versions:
v3 - https://lore.kernel.org/lkml/[email protected]
v2 - https://lore.kernel.org/lkml/[email protected]
v1 - https://lore.kernel.org/lkml/[email protected]

Markus Schneider-Pargmann (6):
dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants
can: tcan4x5x: Remove reserved register 0x814 from writable table
can: tcan4x5x: Check size of mram configuration
can: tcan4x5x: Rename ID registers to match datasheet
can: tcan4x5x: Add support for tcan4552/4553
can: tcan4x5x: Add error messages in probe

 .../devicetree/bindings/net/can/tcan4x5x.txt  |  11 +-
 drivers/net/can/m_can/m_can.c                 |  16 ++
 drivers/net/can/m_can/m_can.h                 |   1 +
 drivers/net/can/m_can/tcan4x5x-core.c         | 142 +++++++++++++++---
 drivers/net/can/m_can/tcan4x5x-regmap.c       |   1 -
 5 files changed, 145 insertions(+), 26 deletions(-)

base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5

Signature · 1 line
2.40.1