Skip to content

Port Xe to use GPUVA and implement NULL VM binds

Matthew Brost intel-xe 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4maple_tree: split up MA_STATE() macroinclude/linux/maple_tree.h+5 -20 replies
2/4drm: manager to keep track of GPUs VA mappingsDocumentation/gpu/drm-mm.rst drivers/gpu/drm/Makefile drivers/gpu/drm/drm_debugfs.c +6 more+2822 -00 replies
3/4drm/xe: Port Xe to GPUVAdrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_exec.c +10 more+1117 -11710 replies
4/4drm/xe: NULL binding implementationdrivers/gpu/drm/xe/xe_bo.h drivers/gpu/drm/xe/xe_exec.c drivers/gpu/drm/xe/xe_gt_pagefault.c +6 more+144 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Intel-xe] [PATCH 0/4] Port Xe to use GPUVA and implement NULL VM binds

GPUVA is common code written primarily by Danilo with the idea being a common place to track GPUVAs (VMAs in Xe) within an address space (VMs in Xe), track all the GPUVAs attached to GEMs, and a common way implement VM binds / unbinds with MMAP / MUNMAP semantics via creating operation lists. All of this adds up to a common way to implement VK sparse bindings.

This series pulls in the GPUVA code written by Danilo plus some small fixes by myself into 1 large patch. Once the GPUVA makes it upstream, we can rebase and drop this patch. I believe what lands upstream should be nearly identical to this patch at least from an API perspective.

The last two patches port Xe to GPUVA and add support for NULL VM binds (writes dropped, read zero, VK sparse support). An example of the semantics of this is below.

MAP 0x0000-0x8000 to NULL - 0x0000-0x8000 writes dropped + read zero
MAP 0x4000-0x5000 to a GEM - 0x0000-0x4000, 0x5000-0x8000 writes dropped + read zero; 0x4000-0x5000 mapped to a GEM
UNMAP 0x3000-0x6000 - 0x0000-0x3000, 0x6000-0x8000 writes dropped + read zero
UNMAP 0x0000-0x8000 - Nothing mapped

No changins to existing behavior, rather just new functionality.

A follow up will optimize REBIND operation to avoid using dma-resv slots for ordering (partial unbinds when not changing page sizes) and prune the xe_vma object data members.

v2: Fix CI build failure

Danilo Krummrich (1):
maple_tree: split up MA_STATE() macro

Matthew Brost (2):
drm/xe: Port Xe to GPUVA
drm/xe: NULL binding implementation

Signed-off-by: Danilo Krummrich (1):
drm: manager to keep track of GPUs VA mappings

 Documentation/gpu/drm-mm.rst                |   31 +
 drivers/gpu/drm/Makefile                    |    1 +
 drivers/gpu/drm/drm_debugfs.c               |   56 +
 drivers/gpu/drm/drm_gem.c                   |    3 +
 drivers/gpu/drm/drm_gpuva_mgr.c             | 1891 +++++++++++++++++++
 drivers/gpu/drm/xe/xe_bo.c                  |   10 +-
 drivers/gpu/drm/xe/xe_bo.h                  |    1 +
 drivers/gpu/drm/xe/xe_device.c              |    2 +-
 drivers/gpu/drm/xe/xe_exec.c                |    4 +-
 drivers/gpu/drm/xe/xe_gt_pagefault.c        |   27 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |   14 +-
 drivers/gpu/drm/xe/xe_guc_ct.c              |    6 +-
 drivers/gpu/drm/xe/xe_migrate.c             |    5 +-
 drivers/gpu/drm/xe/xe_pt.c                  |  166 +-
 drivers/gpu/drm/xe/xe_trace.h               |   10 +-
 drivers/gpu/drm/xe/xe_vm.c                  | 1873 +++++++++---------
 drivers/gpu/drm/xe/xe_vm.h                  |   76 +-
 drivers/gpu/drm/xe/xe_vm_madvise.c          |   87 +-
 drivers/gpu/drm/xe/xe_vm_types.h            |  168 +-
 include/drm/drm_debugfs.h                   |   23 +
 include/drm/drm_drv.h                       |    7 +
 include/drm/drm_gem.h                       |   75 +
 include/drm/drm_gpuva_mgr.h                 |  735 +++++++
 include/linux/maple_tree.h                  |    7 +-
 include/uapi/drm/xe_drm.h                   |    8 +
 25 files changed, 4073 insertions(+), 1213 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_gpuva_mgr.c
 create mode 100644 include/drm/drm_gpuva_mgr.h
Signature · 1 line
2.34.1