Skip to content

powercap/intel_rapl: Introduce RAPL TPMI support

Zhang Rui linux-pm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 4 repliesIn review
  2. v115 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- use set_defaults() and variable name 'defaults' for rapl_defaults structure.
- use 'rpi_default' instead of 'rpis' for the default rapl primitive information of MSR/MMIO Interface.
- rephase the changelog of patch 7/15.
- change the subject of patch 10/15 and use a helper for getting the primitive for power limit LOCK bit control.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15powercap/intel_rapl: Remove unused field in struct rapl_if_privinclude/linux/intel_rapl.h+0 -10 replies
2/15powercap/intel_rapl: Allow probing without CPUID matchdrivers/powercap/intel_rapl_common.c+14 -210 replies
3/15powercap/intel_rapl: Support per Interface rapl_defaultsdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+35 -130 replies
4/15powercap/intel_rapl: Support per Interface primitive informationdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+35 -170 replies
5/15powercap/intel_rapl: Support per domain energy/power/time unitdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+73 -630 replies
6/15powercap/intel_rapl: Use index to initialize primitive informationdrivers/powercap/intel_rapl_common.c+26 -280 replies
7/15powercap/intel_rapl: Change primitive orderdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+5 -40 replies
8/15powercap/intel_rapl: Use bitmap for Power Limitsdrivers/powercap/intel_rapl_common.c drivers/powercap/intel_rapl_msr.c drivers/thermal/intel/int340x_thermal/processor_thermal_rapl.c+11 -130 replies
9/15powercap/intel_rapl: Cleanup Power Limits supportdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+146 -1983 replies
10/15powercap/intel_rapl: Add support for lock bit per Power Limitdrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+32 -200 replies
11/15powercap/intel_rapl: Remove redundant cpu parameterdrivers/powercap/intel_rapl_common.c+13 -130 replies
12/15powercap/intel_rapl: Make cpu optional for rapl_packagedrivers/powercap/intel_rapl_common.c drivers/powercap/intel_rapl_msr.c drivers/thermal/intel/int340x_thermal/processor_thermal_rapl.c +1 more+60 -440 replies
13/15powercap/intel_rapl: Introduce RAPL I/F typedrivers/powercap/intel_rapl_common.c drivers/powercap/intel_rapl_msr.c drivers/thermal/intel/int340x_thermal/processor_thermal_rapl.c +1 more+22 -50 replies
14/15powercap/intel_rapl: Introduce core support for TPMI interfacedrivers/powercap/intel_rapl_common.c include/linux/intel_rapl.h+122 -20 replies
15/15powercap/intel_rapl_tpmi: Introduce RAPL TPMI interface driverdrivers/powercap/Kconfig drivers/powercap/Makefile drivers/powercap/intel_rapl_tpmi.c+340 -00 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by.

PatchWang Wendy
1/15
2/15T-b
3/15T-b
4/15T-b
5/15T-b
6/15T-b
7/15T-b
8/15T-b
9/15T-b
10/15T-b
11/15T-b
12/15T-b
13/15T-b
14/15T-b
15/15T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/15] powercap/intel_rapl: Introduce RAPL TPMI support

The TPMI (Topology Aware Register and PM Capsule Interface) provides a flexible, extendable and PCIe enumerable MMIO interface for PM features.

The TPMI documentation can be downloaded from:
https://github.com/intel/tpmi_power_management

Intel RAPL (Running Average Power Limit) is one of the features that benefit from this. Using TPMI Interface has advantage over traditional MSR (Model Specific Register) interface, where a thread needs to be scheduled on the target CPU to read or write. Also the RAPL features vary between CPU models, and hence lot of model specific code. Here TPMI provides an architectural interface by providing hierarchical tables and fields, which will not need any model specific implementation.

Given that there are some differences between RAPL TPMI Interface and the existing RAPL MSR/MMIO Interface, this patch series improves the RAPL common code to satisfy the new requirements from TPMI interface, and then introduces the RAPL TPMI Interface driver.

Patch 1-4 cleanups and preparation work.
Patch 5 adds support for per Domain Unit register.
Patch 6-10 improves Power Limits handling, and provides support
for per Power Limit register, and per Power Limit Lock.
Patch 11-12 support rapl_package without online CPUs. So that TPMI
rapl_package still works with whole package offlined.
Patch 13-15 introduces RAPL Core support for TPMI Interface and the
RAPL TPMI Interface driver.

This series depends on the TPMI base driver which has been merged in 6.3-rc1.

thanks,
rui
---
Changes since v1:
- use set_defaults() and variable name 'defaults' for rapl_defaults structure.
- use 'rpi_default' instead of 'rpis' for the default rapl primitive information of MSR/MMIO Interface.
- rephase the changelog of patch 7/15.
- change the subject of patch 10/15 and use a helper for getting the primitive for power limit LOCK bit control.

----------------------------------------------------------------
Zhang Rui (15):
powercap/intel_rapl: Remove unused field in struct rapl_if_priv powercap/intel_rapl: Allow probing without CPUID match powercap/intel_rapl: Support per Interface rapl_defaults powercap/intel_rapl: Support per Interface primitive information powercap/intel_rapl: Support per domain energy/power/time unit powercap/intel_rapl: Use index to initialize primitive information powercap/intel_rapl: Change primitive order powercap/intel_rapl: Use bitmap for Power Limits powercap/intel_rapl: Cleanup Power Limits support powercap/intel_rapl: Introduce per Power Limit lock powercap/intel_rapl: Remove redundant cpu parameter powercap/intel_rapl: Make cpu optional for rapl_package powercap/intel_rapl: Introduce RAPL I/F type powercap/intel_rapl: Introduce core support for TPMI interface powercap/intel_rapl_tpmi: Introduce RAPL TPMI interface driver

 drivers/powercap/Kconfig                           |  14 +
 drivers/powercap/Makefile                          |   1 +
 drivers/powercap/intel_rapl_common.c               | 868 ++++++++++++---------
 drivers/powercap/intel_rapl_msr.c                  |  14 +-
 drivers/powercap/intel_rapl_tpmi.c                 | 325 ++++++++
 .../intel/int340x_thermal/processor_thermal_rapl.c |  11 +-
 include/linux/intel_rapl.h                         |  40 +-
 7 files changed, 875 insertions(+), 398 deletions(-)
 create mode 100644 drivers/powercap/intel_rapl_tpmi.c