xsk: Support UMEM chunk_size > PAGE_SIZE
Status from this message: Nacked-by: Toke Høiland-Jørgensen <[email protected]>
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest4 patches 1 replyNAK
- v54 patches 7 repliesSuperseded
- v43 patches 0 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 24 replies | Superseded | |
| v2 | 10 patches | 16 replies | Superseded | |
| v1 | 3 patches | 8 replies | Superseded |
Changes in v6 from the cover letter
* Fix nits from Magnus.
Patches in v6
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | xsk: Use pool->dma_pages to check for DMAinclude/ net/ | +5 | 0 replies | |
| 2/4 | xsk: Support UMEM chunk_size > PAGE_SIZEDocumentation/ include/ include/ +3 more | +108 | 1 reply | |
| 3/4 | selftests: xsk: Use hugepages when umem->frame_size > PAGE_SIZEtools/ | +1 | 0 replies | |
| 4/4 | selftests: xsk: Add tests for 8K and 9K frame sizestools/ tools/ | +27 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Magnus Karlsson | Bagas Sanjaya | Toke Høiland-Jørgensen |
|---|---|---|---|
| 1/4 | A-b | ||
| 2/4 | A-b | R-b | Nacked-by |
| 3/4 | A-b | ||
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH bpf-next v6 0/4] xsk: Support UMEM chunk_size > PAGE_SIZE
The main purpose of this patchset is to add AF_XDP support for UMEM chunk sizes > PAGE_SIZE. This is enabled for UMEMs backed by HugeTLB pages.
Changes since v5:
* Fix nits from Magnus.
Changes since v4:
* Use hugepages in DMA map (fixes zero-copy mode with IOMMU).
* Use pool->dma_pages to check for DMA. This change is needed to avoid performance regressions).
* Update commit message and benchmark table.
Changes since v3:
* Fix checkpatch.pl whitespace error.
Changes since v2:
* Related fixes/improvements included with v2 have been removed. These changes have all been resubmitted as standalone patchsets.
* Minimize uses of #ifdef CONFIG_HUGETLB_PAGE.
* Improve AF_XDP documentation.
* Update benchmark table in commit message.
Changes since v1:
* Add many fixes/improvements to the XSK selftests.
* Add check for unaligned descriptors that overrun UMEM.
* Fix compile errors when CONFIG_HUGETLB_PAGE is not set.
* Fix incorrect use of _Static_assert.
* Update AF_XDP documentation.
* Rename unaligned 9K frame size test.
* Make xp_check_dma_contiguity less conservative.
* Add more information to benchmark table.
Thanks to Magnus Karlsson for all his feedback!
Kal Conley (4):
xsk: Use pool->dma_pages to check for DMA
xsk: Support UMEM chunk_size > PAGE_SIZE
selftests: xsk: Use hugepages when umem->frame_size > PAGE_SIZE
selftests: xsk: Add tests for 8K and 9K frame sizes
Documentation/networking/af_xdp.rst | 36 ++++++++++------ include/net/xdp_sock.h | 2 + include/net/xdp_sock_drv.h | 12 ++++++ include/net/xsk_buff_pool.h | 12 +++--- net/xdp/xdp_umem.c | 55 +++++++++++++++++++----- net/xdp/xsk_buff_pool.c | 41 +++++++++++------- tools/testing/selftests/bpf/xskxceiver.c | 27 +++++++++++- tools/testing/selftests/bpf/xskxceiver.h | 2 + 8 files changed, 141 insertions(+), 46 deletions(-)
Signature · 1 line
2.39.2