Skip to content

bulk: Do not declare function prototypes using 'extern' keyword

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesIn review
  2. v15 patches 4 repliesSuperseded

Since v2 from the cover letter

- Do not change variable declarations in "block/dmg.h" (danpb)
- Rebased
- Added R-b from v1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5util/cacheflush: Use declarations from <OSCacheControl.h> on Darwinutil/cacheflush.c+2 -21 reply
2/5tcg/tcg-op-vec: Remove left over _link_error() definitionstcg/tcg-op-vec.c+0 -111 reply
3/5qemu/uri: Use QueryParams type definitioninclude/qemu/uri.h+1 -11 reply
4/5bulk: Do not declare function prototypes using 'extern' keywordbsd-user/bsd-file.h crypto/hmacpriv.h hw/xen/xen_pt.h +17 more+79 -861 reply
5/5bulk: Replace __attribute__((noreturn)) -> G_NORETURNinclude/sysemu/os-win32.h tests/migration/stress.c+2 -21 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJuan QuintelaRichard HendersonPeter Maydell
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] bulk: Do not declare function prototypes using 'extern' keyword

Since v2:
- Do not change variable declarations in "block/dmg.h" (danpb)
- Rebased
- Added R-b from v1

v1:
- Remove the 'extern' keyword on function prototypes declared in header.
- Replace __attribute__((noreturn)) -> G_NORETURN
- Trivial cleanups to keep the previous commits generic.

Based-on: <[email protected]>

Philippe Mathieu-Daudé (5):
util/cacheflush: Use declarations from <OSCacheControl.h> on Darwin tcg/tcg-op-vec: Remove left over _link_error() definitions qemu/uri: Use QueryParams type definition
bulk: Do not declare function prototypes using 'extern' keyword
bulk: Replace __attribute__((noreturn)) -> G_NORETURN

 bsd-user/bsd-file.h            |  6 ++---
 crypto/hmacpriv.h              | 13 +++++------
 hw/xen/xen_pt.h                |  8 +++----
 include/crypto/secret_common.h | 14 +++++-------
 include/exec/page-vary.h       |  4 ++--
 include/hw/misc/aspeed_scu.h   |  2 +-
 include/hw/nvram/npcm7xx_otp.h |  4 ++--
 include/hw/qdev-core.h         |  4 ++--
 include/qemu/crc-ccitt.h       |  4 ++--
 include/qemu/osdep.h           |  4 ++--
 include/qemu/rcu.h             | 14 ++++++------
 include/qemu/sys_membarrier.h  |  4 ++--
 include/qemu/uri.h             |  6 ++---
 include/sysemu/accel-blocker.h | 14 ++++++------
 include/sysemu/os-win32.h      |  4 ++--
 include/user/safe-syscall.h    |  4 ++--
 target/i386/sev.h              |  6 ++---
 target/mips/cpu.h              |  4 ++--
 tcg/tcg-internal.h             |  4 ++--
 include/exec/memory_ldst.h.inc | 42 +++++++++++++++++-----------------
 tcg/tcg-op-vec.c               | 11 ---------
 tests/migration/stress.c       |  2 +-
 util/cacheflush.c              |  4 ++--
 23 files changed, 82 insertions(+), 100 deletions(-)
Signature · 1 line
2.38.1