tst_device.c: Handle Android path for backing device
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 1 replyIn review
- v34 patches 5 repliesSuperseded
- v23 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 0 replies | Superseded |
Changes in v4 from the cover letter
Rename dev_len argument to dev_size and update documentation and references. Remove != 0 as it is redundant.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | set_dev_path: Rename to set_dev_loop_pathlib/ | +6 | 0 replies | |
| 2/4 | set_dev_loop_path: Change return value to zero on successlib/ | +3 | 0 replies | |
| 3/4 | tst_find_free_loopdev: Check return value of set_dev_loop_pathlib/ | +2 | 0 replies | |
| 4/4 | tst_find_backing_dev: Also check /dev/block/ for backing devicedoc/ include/ lib/ +2 more | +33 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Petr Vorel | Cyril Hrubis |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [LTP] [PATCH v4 0/4] tst_device.c: Handle Android path for backing device
e1b1ae66b240 ("tst_find_backing_dev: Get dev name from /sys/dev/block/*/uevent") added a hardcoded path to check for the backing device in /dev. On Android, it needs to check /dev/block.
The set_dev_path function was renamed to set_dev_loop_path and its return value was changed from 1 on success to 0 on success to be more consistent with other functions. A check was added to tst_find_free_loopdev in the event that the loop device is not ready yet, which appears to happen occasionally on Android.
v1->v2:
Changed the function signature of tst_find_backing_dev to add the length of the path string. Updated all references for this function to include the added parameter.
v2->v3:
Split the function rename, return value change, and the return value check into 3 commits. Fixed logic for non-NULL path check. Added Fixes tag for e1b1ae66b240.
v3->v4:
Rename dev_len argument to dev_size and update documentation and references. Remove != 0 as it is redundant.
Edward Liaw (4):
set_dev_path: Rename to set_dev_loop_path
set_dev_loop_path: Change return value to zero on success
tst_find_free_loopdev: Check return value of set_dev_loop_path
tst_find_backing_dev: Also check /dev/block/ for backing device
doc/c-test-api.txt | 2 +- include/tst_device.h | 7 +-- lib/newlib_tests/tst_device.c | 2 +- lib/tst_device.c | 51 ++++++++++++------- .../kernel/syscalls/ioctl/ioctl_loop05.c | 2 +- 5 files changed, 40 insertions(+), 24 deletions(-)
Signature · 5 lines
2.40.0.348.gf938b09366-goog -- Mailing list info: https://lists.linux.it/listinfo/ltp