Skip to content

RFC Add CPPC extension support in OpenSBI

Sunil V L opensbi 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest4 patches 0 repliesNew
  2. v4 RFC4 patches 0 repliesSuperseded
  3. v3 RFC4 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC4 patches0 repliesSuperseded
v1 RFC4 patches0 repliesSuperseded

Changes in v5 from the cover letter

1) Updated as per latest draft which removed the mandatory/optional attribute.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4include: Add defines for SBI CPPC extensioninclude/sbi/sbi_ecall_interface.h+34 -01 reply
2/4lib: sbi: Implement SBI CPPC extensioninclude/sbi/sbi_cppc.h lib/sbi/Kconfig lib/sbi/objects.mk +2 more+216 -01 reply
3/4lib: sbi: Print the CPPC device namelib/sbi/sbi_init.c+5 -01 reply
4/4NOT_FOR_MERGE: Add test code to emulate CPPC extensioninclude/sbi/sbi_cppc.h platform/generic/objects.mk platform/generic/platform.c +1 more+169 -00 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesAnup Patel
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [RFC PATCH v5 0/4] Add CPPC extension support in OpenSBI

The latest proposal of SBI CPPC extension can be found at:
https://lists.riscv.org/g/tech-prs/message/365

This series implements SBI CPPC extension support in OpenSBI as-per above draft proposal.

To test these patches,
Qemu patches can be found in,
aia_plic_cppc_v1 branch at: https://github.com/vlsunil/qemu.git
Linux patches can be found in
aia_plic_cppc_v1 branch at: https://github.com/vlsunil/linux.git

These OpenSBI patches can also be found in aia_plic_cppc_v5 branch at: https://github.com/vlsunil/opensbi.git

Changes since v4:
1) Updated as per latest draft which removed the mandatory/optional attribute.

Changes since v3:
1) Updated as per latest draft of CPPC extension proposal which made few mandatory registers as optional.

Changes since v2:
1) Updated probe, read/write functions as per Drew's feedback to split between common and platform specific functions.

Changes since v1:
1) Addresses Drew's feedback
a) Updated common functions to handle most of the errors.
b) Added is_reserved, readable, writable helpers as per Drew's feedback.
c) Updated macro name to SBI_CPPC_ENERGY_PERF_PREFERENCE
2) Updated RB tags

Sunil V L (4):
include: Add defines for SBI CPPC extension
lib: sbi: Implement SBI CPPC extension
lib: sbi: Print the CPPC device name
NOT_FOR_MERGE: Add test code to emulate CPPC extension

 include/sbi/sbi_cppc.h            |  37 +++++++
 include/sbi/sbi_ecall_interface.h |  34 +++++++
 lib/sbi/Kconfig                   |   4 +
 lib/sbi/objects.mk                |   4 +
 lib/sbi/sbi_cppc.c                | 110 ++++++++++++++++++++
 lib/sbi/sbi_ecall_cppc.c          |  63 ++++++++++++
 lib/sbi/sbi_init.c                |   5 +
 platform/generic/objects.mk       |   1 +
 platform/generic/platform.c       |   6 ++
 platform/generic/test_cppc.c      | 160 ++++++++++++++++++++++++++++++
 10 files changed, 424 insertions(+)
 create mode 100644 include/sbi/sbi_cppc.h
 create mode 100644 lib/sbi/sbi_cppc.c
 create mode 100644 lib/sbi/sbi_ecall_cppc.c
 create mode 100644 platform/generic/test_cppc.c
Signature · 1 line
2.34.1