Skip to content

hw/cxl: Fix decoder commit and uncommit handling

Jonathan Cameron linux-cxl qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Split dropping the transaction guards out as precursor (Phillipe)
- Picked up tags

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/cxl: drop pointless memory_region_transaction_guardshw/cxl/cxl-component-utils.c+0 -20 replies
2/3hw/cxl: Fix endian handling for decoder commit.hw/cxl/cxl-component-utils.c hw/mem/cxl_type3.c+10 -70 replies
3/3hw/cxl: Fix incorrect reset of commit and associated clearing of committed.hw/cxl/cxl-component-utils.c hw/mem/cxl_type3.c+25 -20 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéFan NiDave Jiang
1/3R-b
2/3R-b
3/3R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] hw/cxl: Fix decoder commit and uncommit handling

v2:
- Split dropping the transaction guards out as precursor (Phillipe)
- Picked up tags

Issue reported in discussion of:
https://lore.kernel.org/all/[email protected]/

The committed bit for HDM decoders is expected reset when commit transitions from 1->0. Whilst looking at that it was noticed that hardware was resetting the commit bit which is not an option allowed by the CXL spec.

In common with many other areas the code did not take into account big endian architectures, so fix that whilst we are here.

Note testing this exposed a kernel bug around repeated attempts to clear a decoder out of order. That's been reported but not yet fixed.

Jonathan Cameron (3):
hw/cxl: drop pointless memory_region_transaction_guards hw/cxl: Fix endian handling for decoder commit. hw/cxl: Fix incorrect reset of commit and associated clearing of
committed.

 hw/cxl/cxl-component-utils.c | 14 ++++++++------
 hw/mem/cxl_type3.c           | 28 +++++++++++++++++++++++++---
 2 files changed, 33 insertions(+), 9 deletions(-)
Signature · 1 line
2.37.2