Skip to content

sed-opal: add command to read locking range attributes

Ondrej Kozina linux-block 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyApplied
  2. v15 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Mostly code style fixes (overly long lines)
- Refactored helper for adding user authorities in ACE (added boolean operators defines, explained addition of boolean ace operator when adding more than one user authority in ACE)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5sed-opal: do not add same authority twice in boolean ace.block/sed-opal.c+0 -160 replies
2/5sed-opal: add helper for adding user authorities in ACE.block/opal_proto.h block/sed-opal.c+77 -200 replies
3/5sed-opal: allow user authority to get locking range attributes.block/opal_proto.h block/sed-opal.c+25 -00 replies
4/5sed-opal: add helper to get multiple columns at once.block/sed-opal.c+14 -80 replies
5/5sed-opal: Add command to read locking range parameters.block/sed-opal.c include/linux/sed-opal.h include/uapi/linux/sed-opal.h+165 -00 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchLuca BoccassiMilan BrozChristoph HellwigChristian Brauner
1/5T-b T-b R-b A-b
2/5T-b T-b
3/5T-b T-b R-b A-b
4/5T-b T-b R-b A-b
5/5T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] sed-opal: add command to read locking range attributes

This patch set aims to add ability to user authorities to read locking range attributes.

It's achieved in two steps (except SUM enabled drives):

1) Patch IOC_OPAL_ADD_USR_TO_LR command so that user authority (together with OPAL_ADMIN1) is added in ACE that allows getting locking range attributes.

2) Add new ioctl command IOC_OPAL_GET_LR_STATUS to get locking range attributes to user authority assigned to specific locking range.

libcryptsetup plans to support OPAL2 drives and needs to verify locking range parameters before device activation (LR unlock) takes place since it's considered undesirable to have (for example) partition mapped beyond locking range boundaries.

Changes since previous version:

v2:
- Mostly code style fixes (overly long lines)
- Refactored helper for adding user authorities in ACE (added boolean operators defines, explained addition of boolean ace operator when adding more than one user authority in ACE)

Ondrej Kozina (5):
sed-opal: do not add same authority twice in boolean ace.
sed-opal: add helper for adding user authorities in ACE.
sed-opal: allow user authority to get locking range attributes.
sed-opal: add helper to get multiple columns at once.
sed-opal: Add command to read locking range parameters.

 block/opal_proto.h            |  10 ++
 block/sed-opal.c              | 301 +++++++++++++++++++++++++++++-----
 include/linux/sed-opal.h      |   1 +
 include/uapi/linux/sed-opal.h |  11 ++
 4 files changed, 280 insertions(+), 43 deletions(-)
Signature · 1 line
2.31.1