Skip to content

erofs: cleanup of xattr handling

Jingbo Xu linux-erofs lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 2 repliesIn review
  2. v75 patches 3 repliesSuperseded
  3. v65 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v56 patches5 repliesSuperseded
v45 patches8 repliesSuperseded
v35 patches4 repliesSuperseded
v28 patches8 repliesSuperseded
v18 patches3 repliesSuperseded

Changes in v8 from the cover letter

- patch 1: add Reviewed-by tag
- patch 4: s/erofs_iter_inline_xattr/erofs_xattr_iter_inline s/erofs_iter_shared_xattr/erofs_xattr_iter_shared
- patch 5: polish commit message; tweak overly long lines

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5erofs: use absolute position in xattr iteratorfs/erofs/xattr.c+65 -970 replies
2/5erofs: unify xattr_iter structuresfs/erofs/xattr.c+62 -840 replies
3/5erofs: make the size of read data stored in buffer_ofsfs/erofs/xattr.c+3 -30 replies
4/5erofs: unify inline/shared xattr iterators for listxattr/getxattrfs/erofs/xattr.c+73 -1151 reply
5/5erofs: use separate xattr parsers for listxattr/getxattrfs/erofs/xattr.c+137 -2341 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchGao Xiang
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/5] erofs: cleanup of xattr handling

changes since v7:
- patch 1: add Reviewed-by tag
- patch 4: s/erofs_iter_inline_xattr/erofs_xattr_iter_inline s/erofs_iter_shared_xattr/erofs_xattr_iter_shared
- patch 5: polish commit message; tweak overly long lines

changes since v6:
- patch 1: s/__u32/__le32 in calculation of it->pos (Gao Xiang)
- patch 4: polish the commit message (Gao Xiang)
- patch 5: s/erofs_xattr_handle_string/erofs_xattr_copy_to_buffer (Gao Xiang)

changes since v5:
- patch 1: newly added into this series, in preparation for the following cleanup
- patch 5: rename erofs_xattr_body() to erofs_xattr_handle_string()

changes since v4:
- patch 1: make conversions from erofs_read_metabuf() in xattr.c to "erofs_init_metabuf() + erofs_bread()" a separate patch
- patch 6: add "bool copy" function parameter to erofs_xattr_body(), and thus make erofs_xattr_namematch() and erofs_xattr_copy() inlined inside erofs_xattr_body()

changes since v3:
- patch 1: make a unified erofs_xattr_iter_fixup() API with newly introduced "bool nospan" argument; call erofs_init_metabuf() and erofs_bread() separately instead of erofs_read_metabuf()
- patch 2: avoid duplicated strlen() calculation in erofs_getxattr(); no need zeroing other fields when initializing 'struct erofs_xattr_iter'
- patch 4: don't explode 'struct erofs_xattr_iter' with inode/getxattr fields; instead pass inode/getxattr parameters through function parameters of erofs_iter_[inline|shared]_xattr()
- patch 5: don't explode 'struct erofs_xattr_iter' with remaining field; instead calculate and check the remaining inside erofs_iter_inline_xattr()

changes since v2:
- rebase to v6.4-rc2
- passes xattr tests (erofs/019,020,021) of erofs-utils [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/log/?h=experimental-tests

v7: https://lore.kernel.org/all/[email protected]/
v6: https://lore.kernel.org/all/[email protected]/
v5: https://lore.kernel.org/all/[email protected]/
v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Jingbo Xu (5):
erofs: use absolute position in xattr iterator
erofs: unify xattr_iter structures
erofs: make the size of read data stored in buffer_ofs
erofs: unify inline/shared xattr iterators for listxattr/getxattr
erofs: use separate xattr parsers for listxattr/getxattr

 fs/erofs/xattr.c | 663 +++++++++++++++++------------------------------
 1 file changed, 235 insertions(+), 428 deletions(-)
Signature · 1 line
2.19.1.6.gb485710b