Skip to content

nvmet-tcp: add module parameter check

Chaitanya Kulkarni linux-nvme 1 version Applied

Status from this message: applied to nvme-6.4.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2nvmet-tcp: validate so_priority modparam valuedrivers/nvme/target/tcp.c+27 -21 reply
2/2nvmet-tcp: validate idle poll modparam valuedrivers/nvme/target/tcp.c+3 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSagi Grimberg
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] nvmet-tcp: add module parameter check

Hi,

Add module parameter check for the nvme-tcp target to generate right error for negative values set by user at the time of the module loading instaed of allowing module to be loaded with those values, that created confusion, simple testing log :-

####################################
Without this patch series
####################################
modprobe nvmet-tcp so_priority=-2 returned 0 modprobe nvmet-tcp so_priority=-1 returned 0 modprobe nvmet-tcp so_priority=0 returned 0 modprobe nvmet-tcp so_priority=1 returned 0 modprobe nvmet-tcp so_priority=100 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=-2 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=-1 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=0 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=1 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=100 returned 0

####################################
With this patch series
####################################
Applying: nvmet-tcp: validate so_priority modparam value
Applying: nvmet-tcp: validate idle poll modparam value

modprobe: ERROR: could not insert 'nvmet_tcp': Invalid argument modprobe nvmet-tcp so_priority=-2 returned 1

[21625.237738] nvmet_tcp: `-2' invalid for parameter `so_priority'

modprobe: ERROR: could not insert 'nvmet_tcp': Invalid argument modprobe nvmet-tcp so_priority=-1 returned 1

[21625.268026] nvmet_tcp: `-1' invalid for parameter `so_priority'

modprobe nvmet-tcp so_priority=0 returned 0
modprobe nvmet-tcp so_priority=1 returned 0
modprobe nvmet-tcp so_priority=100 returned 0

modprobe: ERROR: could not insert 'nvmet_tcp': Invalid argument modprobe nvmet-tcp idle_poll_period_usecs=-2 returned 1

[21625.412338] nvmet_tcp: `-2' invalid for parameter `idle_poll_period_usecs'

modprobe: ERROR: could not insert 'nvmet_tcp': Invalid argument modprobe nvmet-tcp idle_poll_period_usecs=-1 returned 1

[21625.446106] nvmet_tcp: `-1' invalid for parameter `idle_poll_period_usecs'

modprobe nvmet-tcp idle_poll_period_usecs=0 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=1 returned 0 modprobe nvmet-tcp idle_poll_period_usecs=100 returned 0

-ck

Chaitanya Kulkarni (2):
nvmet-tcp: validate so_priority modparam value
nvmet-tcp: validate idle poll modparam value

 drivers/nvme/target/tcp.c | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)
Signature · 1 line
2.29.0