Skip to content

ASoC: SOF: Intel: hda-mlink: HDaudio multi-link extension update

Peter Ujfalusi alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 2 repliesIn review
  2. v118 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Rename hda_bus_ml_get_capabilities() to hda_bus_ml_init() - patch 06/18
- Rename check_power_active() to check_sublink_power() and the parameter from enable to enabled - patch 08/18

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18Documentation: sound: add description of Intel HDaudio multi-linksDocumentation/sound/hd-audio/index.rst Documentation/sound/hd-audio/intel-multi-link.rst+313 -00 replies
2/18ALSA: hda: add HDaudio Extended link definitionsinclude/sound/hda_register.h+38 -20 replies
3/18ASoC: SOF: Intel: hda-mlink: improve hda_bus_ml_free() helpersound/soc/sof/intel/hda-mlink.c+2 -30 replies
4/18ASoC: SOF: Intel: hda-mlink: add return value for hda_bus_ml_get_capabilities()sound/soc/sof/intel/hda-mlink.c sound/soc/sof/intel/hda.h+5 -40 replies
5/18ASoC: SOF: Intel: hda-mlink: move to a dedicated moduleinclude/sound/hda-mlink.h sound/soc/sof/intel/Kconfig sound/soc/sof/intel/Makefile +5 more+57 -340 replies
6/18ASoC: SOF: Intel: hda-mlink: add structures to parse ALT linksinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c sound/soc/sof/intel/hda.c+219 -80 replies
7/18ASoC: SOF: Intel: hda-mlink: special-case HDaudio regular linkssound/soc/sof/intel/hda-mlink.c+22 -40 replies
8/18ASoC: SOF: Intel: hda-mlink: introduce helpers for 'extended links' PMinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+195 -00 replies
9/18ASoC: SOF: Intel: hda-mlink: add convenience helpers for SoundWire PMinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+21 -00 replies
10/18ASoC: SOF: Intel: hda-mlink: add helper to return sublink countinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+17 -00 replies
11/18ASoC: SOF: Intel: hda-mlink: add helpers to enable/check interruptsinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+70 -00 replies
12/18ASoC: SOF: Intel: hda-mlink: add helpers to set link SYNC frequencyinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+117 -00 replies
13/18ASoC: SOF: Intel: hda-mlink: add helpers for sync_arm/sync_goinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+88 -00 replies
14/18ASoC: SOF: Intel: hda-mlink: add helper to check cmdsyncinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+47 -00 replies
15/18ASoC: SOF: Intel: hda-mlink: program SoundWire LSDIID registersinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+35 -00 replies
16/18ASoC: SOF: Intel: hda-mlink: add helpers to retrieve DMIC/SSP hlinkinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+34 -00 replies
17/18ASoC: SOF: Intel: hda-mlink: add helper to offload link ownershipinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+43 -00 replies
18/18ASoC: SOF: Intel: hda-mlink: add helper to retrieve eml_lockinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+17 -00 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRander WangPéter UjfalusiRanjani SridharanTakashi Iwai
SeriesR-b
1/18R-b R-b R-b
2/18R-b R-b R-b
3/18R-b R-b R-b
4/18R-b R-b R-b
5/18R-b R-b R-b
6/18R-b R-b R-b
7/18R-b R-b R-b
8/18R-b R-b R-b
9/18R-b R-b R-b
10/18R-b R-b R-b
11/18R-b R-b R-b
12/18R-b R-b R-b
13/18R-b R-b R-b
14/18R-b R-b R-b
15/18R-b R-b R-b
16/18R-b R-b R-b
17/18R-b R-b R-b
18/18R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/18] ASoC: SOF: Intel: hda-mlink: HDaudio multi-link extension update

Hi,

Changes since v1:
- Rename hda_bus_ml_get_capabilities() to hda_bus_ml_init() - patch 06/18
- Rename check_power_active() to check_sublink_power() and the parameter from enable to enabled - patch 08/18

Not changed: the poll timeout implementation for now, as Pierre mentioned it can be done at a later time.

Cover letter:

The following series adds the core support to handle the recently updated HDaudio multi-link support to hanlde non HDA links, like SoundWire/DMIC/SSP on Intel platform.

For details, please see the first patch which documents the current mlink support (introduced at Skylake) and the new extensions, arriving with LNL.

There is no change in functionality for existing HDA support, the extension is backwards compatible with existing implementations.

Regards,
Peter
---
Pierre-Louis Bossart (18):
Documentation: sound: add description of Intel HDaudio multi-links
ALSA: hda: add HDaudio Extended link definitions
ASoC: SOF: Intel: hda-mlink: improve hda_bus_ml_free() helper
ASoC: SOF: Intel: hda-mlink: add return value for
hda_bus_ml_get_capabilities()
ASoC: SOF: Intel: hda-mlink: move to a dedicated module
ASoC: SOF: Intel: hda-mlink: add structures to parse ALT links
ASoC: SOF: Intel: hda-mlink: special-case HDaudio regular links
ASoC: SOF: Intel: hda-mlink: introduce helpers for 'extended links' PM
ASoC: SOF: Intel: hda-mlink: add convenience helpers for SoundWire PM
ASoC: SOF: Intel: hda-mlink: add helper to return sublink count
ASoC: SOF: Intel: hda-mlink: add helpers to enable/check interrupts
ASoC: SOF: Intel: hda-mlink: add helpers to set link SYNC frequency
ASoC: SOF: Intel: hda-mlink: add helpers for sync_arm/sync_go
ASoC: SOF: Intel: hda-mlink: add helper to check cmdsync
ASoC: SOF: Intel: hda-mlink: program SoundWire LSDIID registers
ASoC: SOF: Intel: hda-mlink: add helpers to retrieve DMIC/SSP hlink
ASoC: SOF: Intel: hda-mlink: add helper to offload link ownership
ASoC: SOF: Intel: hda-mlink: add helper to retrieve eml_lock

 Documentation/sound/hd-audio/index.rst        |   1 +
 .../sound/hd-audio/intel-multi-link.rst       | 312 +++++++
 include/sound/hda-mlink.h                     | 166 ++++
 include/sound/hda_register.h                  |  40 +-
 sound/soc/sof/intel/Kconfig                   |   7 +
 sound/soc/sof/intel/Makefile                  |   5 +-
 sound/soc/sof/intel/hda-ctrl.c                |   1 +
 sound/soc/sof/intel/hda-dsp.c                 |   1 +
 sound/soc/sof/intel/hda-mlink.c               | 822 +++++++++++++++++-
 sound/soc/sof/intel/hda.c                     |   4 +-
 sound/soc/sof/intel/hda.h                     |  20 -
 11 files changed, 1332 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/sound/hd-audio/intel-multi-link.rst
 create mode 100644 include/sound/hda-mlink.h
Signature · 1 line
2.40.0