Skip to content

config file/command line for objdump & addr2line

Ian Rogers linux-perf-users lkml llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6perf annotate: Delete session for debug buildstools/perf/builtin-annotate.c+6 -105 replies
2/6perf report: Additional config warningstools/perf/builtin-report.c+5 -00 replies
3/6perf annotate: Add init/exit to annotation_options remove defaulttools/perf/builtin-annotate.c tools/perf/builtin-report.c tools/perf/builtin-top.c +2 more+29 -150 replies
4/6perf annotate: Own objdump_path and disassembler_style stringstools/perf/arch/common.c tools/perf/arch/common.h tools/perf/builtin-annotate.c +4 more+56 -131 reply
5/6perf annotate: Allow objdump to be set in perfconfigtools/perf/Documentation/perf-config.txt tools/perf/util/annotate.c+10 -10 replies
6/6perf symbol: Add command line support for addr2line pathtools/perf/Documentation/perf-annotate.txt tools/perf/Documentation/perf-config.txt tools/perf/Documentation/perf-report.txt +7 more+62 -141 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/6] config file/command line for objdump & addr2line

Allow objdump to be set as a perf config file variable. As previously objdump was set via the command line, the string was owned by argv. Now the string must be strdup-ed, so the corresponding logic needs changing with an annotation_options__init/exit.

Add command line and config file options for addr2line, set in symbol_conf for convenience. This doesn't allow the setting of llvm-addr2line due to a bug, but could in the future.

Ian Rogers (6):
perf annotate: Delete session for debug builds
perf report: Additional config warnings
perf annotate: Add init/exit to annotation_options remove default perf annotate: Own objdump_path and disassembler_style strings perf annotate: Allow objdump to be set in perfconfig perf symbol: Add command line support for addr2line path

 tools/perf/Documentation/perf-annotate.txt |  3 ++
 tools/perf/Documentation/perf-config.txt   |  8 +++-
 tools/perf/Documentation/perf-report.txt   |  3 ++
 tools/perf/Documentation/perf-top.txt      |  6 +++
 tools/perf/arch/common.c                   |  4 +-
 tools/perf/arch/common.h                   |  2 +-
 tools/perf/builtin-annotate.c              | 42 +++++++++++++-------
 tools/perf/builtin-report.c                | 35 ++++++++++++++---
 tools/perf/builtin-top.c                   | 27 +++++++++++--
 tools/perf/util/annotate.c                 | 45 +++++++++++++++++-----
 tools/perf/util/annotate.h                 |  9 +++--
 tools/perf/util/srcline.c                  | 26 ++++++++-----
 tools/perf/util/symbol_conf.h              |  1 +
 13 files changed, 163 insertions(+), 48 deletions(-)
Signature · 1 line
2.40.0.348.gf938b09366-goog