module: avoid userspace pressure on unwanted allocations
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 3 repliesIn review
- v26 patches 16 repliesSuperseded
- v17 patches 17 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | module: fix kmemleak annotations for non init ELF sectionskernel/ | +10 | 1 reply | |
| 2/4 | module: extract patient module check into helperkernel/ | +60 | 0 replies | |
| 3/4 | module: add debug stats to help identify memory pressureDocumentation/ kernel/ kernel/ +5 more | +630 | 3 replies | |
| 4/4 | module: avoid allocation if module is already present and readykernel/ kernel/ | +12 | 0 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Song Liu | David Hildenbrand | Catalin Marinas |
|---|---|---|---|
| 1/4 | A-b | R-b | |
| 2/4 | R-b | ||
| 3/4 | |||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/4] module: avoid userspace pressure on unwanted allocations
This v3 series follows up on the second iteration of these patches [0]. This and other pending changes are avaiable on 20230413-module-alloc-opts branch [1] which is based on modules-next.
Changes on this v3:
o Catalin Marinas suggested we just use kmemleak_not_leak() for both ELF allocations even if its init stuff.
o Considerable amount of effort went into trying to see if there's relationship with CPU count and wasted virtual memory allocations. The new module debugfs counters helped with creating this evaluation. The result of that put me on a path to then add even more debugging facilities to rule out and identify the culprits. In the end I have patches now which can get this down to 0 bytes wasted. The patch in this series which helps reduce the allocations has a graph showing the findings of the relationship between wasted virtual memory allocations and CPU count all during boot. It is insanity that the graph has to go into gigabytes of wasted virtual memory all at boot.
o To help folks compare apples to apples I've put the stats debug patch *prior* to the one that helps with allocations. This way folks can see for themselves what the results look like.
o Enhanced the statistics a bit more and added an example with 255 CPUs.
o Went with atomic_long and casting for the debugs big counters.
o Rolled in the patch that moved a helper as David suggested.
o Minor fixes reported by 0-day
o Added tags for Reviews, etc.
[0] https://lkml.kernel.org/r/[email protected]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230413-module-alloc-opts
Luis Chamberlain (4):
module: fix kmemleak annotations for non init ELF sections
module: extract patient module check into helper
module: add debug stats to help identify memory pressure
module: avoid allocation if module is already present and ready
Documentation/core-api/kernel-api.rst | 22 +- kernel/module/Kconfig | 37 +++ kernel/module/Makefile | 1 + kernel/module/decompress.c | 4 + kernel/module/internal.h | 74 +++++ kernel/module/main.c | 194 ++++++++---- kernel/module/stats.c | 432 ++++++++++++++++++++++++++ kernel/module/tracking.c | 7 +- 8 files changed, 703 insertions(+), 68 deletions(-) create mode 100644 kernel/module/stats.c
Signature · 1 line
2.39.2