AMDGPU Doorbell manager
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest12 patches 8 repliesIn review
- v212 patches 15 repliesSuperseded
- v116 patches 70 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | drm/amdgpu: create a new file for doorbell managerdrivers/ drivers/ drivers/ +1 more | +195 | 0 replies | |
| 2/12 | drm/amdgpu: don't modify num_doorbells for mesdrivers/ | +15 | 0 replies | |
| 3/12 | drm/amdgpu: add UAPI for allocating doorbell memoryinclude/ | +6 | 0 replies | |
| 4/12 | drm/amdgpu: accommodate DOMAIN/PL_DOORBELLdrivers/ drivers/ drivers/ +2 more | +30 | 0 replies | |
| 5/12 | drm/amdgpu: initialize ttm for doorbellsdrivers/ | +7 | 0 replies | |
| 6/12 | drm/amdgpu: create kernel doorbell pagesdrivers/ drivers/ drivers/ +1 more | +60 | 6 replies | |
| 7/12 | get absolute offset from doorbell indexdrivers/ drivers/ | +24 | 0 replies | |
| 8/12 | drm/amdgpu: use doorbell manager for kfd kernel doorbellsdrivers/ drivers/ drivers/ | +39 | 1 reply | |
| 9/12 | drm/amdgpu: use doorbell manager for kfd process doorbellsdrivers/ drivers/ drivers/ +3 more | +108 | 1 reply | |
| 10/12 | drm/amdgpu: remove unused functions and variablesdrivers/ drivers/ | +0 | 0 replies | |
| 11/12 | drm/amdgpu: use doorbell mgr for MES kernel doorbellsdrivers/ drivers/ | +40 | 3 replies | |
| 12/12 | drm/amdgpu: cleanup MES process level doorbellsdrivers/ drivers/ | +1 | 0 replies |
Reviews trailers per patch
10 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Christian Koenig | Alex Deucher | Felix Kuehling |
|---|---|---|---|
| 1/12 | R-b | ||
| 2/12 | R-b | A-b | |
| 3/12 | R-b | ||
| 4/12 | R-b | ||
| 5/12 | R-b | ||
| 6/12 | |||
| 7/12 | A-b | ||
| 8/12 | R-b | ||
| 9/12 | A-b | R-b | |
| 10/12 | R-b | ||
| 11/12 | |||
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/12] AMDGPU Doorbell manager
Doorbells in AMDGPU drivers are currently managed by different clients in a scattered way, across may places. The existing clients are:
- AMDGPU graphics driver for kernel level doorbell writes.
- AMDGPU MES module for kernel level doorbell write (MES ring test and aggregated doorbells).
- AMDGPU MES module for MES process doorbells.
- AMDKFD module for KFD/KIQ kernel doorbells.
- AMDKFD module for KFD process doorbells.
- AMDGPU usermode queues for usermode doorbell writes (upcoming).
This patch series introduces doorbell-manager to keep the doorbell handling at a central place. The fundamental changes are:
- Introduce and accommodate a new GEM domain for doorbells.
- Prepare the AMDGPU ttm backend for handling doorbell allocation.
- Create doorbell BOs for kernel-level and process level doorbell opertations, and place it in existing structures.
- Modify the existing graphics, KFD and MES code to use the doorbell-manager functions.
- Remove the existing doorbell management code in KFD/MES.
The idea is that:
- a kernel client can call doorbell manager functions to allocate/free doorbell pages.
- a usermode app can directly allocate a page from the doorbell bar just like a GEM object and use it for different usermode queues.
- There is no direct UAPI change in this series, just an additional flag for GEM_OBJECT_DOORBELL, here:
https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/287
PS: This series has been sanity tested with kfd_test_suit to ensure
it is not introducing any regressions due to kfd doorbell changes.
Alex Deucher (2):
drm/amdgpu: add UAPI for allocating doorbell memory drm/amdgpu: accommodate DOMAIN/PL_DOORBELL
Shashank Sharma (10):
drm/amdgpu: create a new file for doorbell manager drm/amdgpu: don't modify num_doorbells for mes drm/amdgpu: initialize ttm for doorbells drm/amdgpu: create kernel doorbell pages
get absolute offset from doorbell index drm/amdgpu: use doorbell manager for kfd kernel doorbells drm/amdgpu: use doorbell manager for kfd process doorbells drm/amdgpu: remove unused functions and variables drm/amdgpu: use doorbell mgr for MES kernel doorbells drm/amdgpu: cleanup MES process level doorbells
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 174 +------------ drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 17 +- .../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 230 +++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 148 +++-------- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 + .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 30 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 20 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 - .../drm/amd/amdkfd/kfd_device_queue_manager.c | 8 +- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 232 ++++++++---------- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 27 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 40 +-- .../amd/amdkfd/kfd_process_queue_manager.c | 23 +- include/uapi/drm/amdgpu_drm.h | 7 +- 19 files changed, 487 insertions(+), 505 deletions(-) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
Signature · 1 line
2.40.1