Skip to content

drm/msm: Convert fbdev to DRM client

Thomas Zimmermann dri-devel linux-arm-msm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/msm: Clear aperture ownership outside of fbdev codedrivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_fbdev.c+6 -62 replies
2/6drm/msm: Remove fb from struct msm_fbdevdrivers/gpu/drm/msm/msm_fbdev.c+13 -191 reply
3/6drm/msm: Remove struct msm_fbdevdrivers/gpu/drm/msm/msm_fbdev.c+3 -161 reply
4/6drm/msm: Remove fbdev from struct msm_drm_privatedrivers/gpu/drm/msm/msm_debugfs.c drivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_drv.h +1 more+6 -131 reply
5/6drm/msm: Initialize fbdev DRM clientdrivers/gpu/drm/msm/msm_fbdev.c+36 -21 reply
6/6drm/msm: Implement fbdev emulation as in-kernel clientdrivers/gpu/drm/msm/msm_debugfs.c drivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_drv.h +1 more+80 -590 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchDmitry Baryshkov
1/6
2/6R-b
3/6
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] drm/msm: Convert fbdev to DRM client

Convert msm' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in msm is now just another DRM client that runs after the DRM device has been registered.

Once all drivers' fbdev emulation has been converted to struct drm_client, we can attempt to add additional in-kernel clients. A DRM-based dmesg log or a bootsplash are commonly mentioned. DRM can then switch easily among the existing clients if/when required.

I did the conversion from similar experience with other drivers. But I don't have the hardware to test this. Any testing is welcome.

Thomas Zimmermann (6):
drm/msm: Clear aperture ownership outside of fbdev code drm/msm: Remove fb from struct msm_fbdev drm/msm: Remove struct msm_fbdev
drm/msm: Remove fbdev from struct msm_drm_private drm/msm: Initialize fbdev DRM client
drm/msm: Implement fbdev emulation as in-kernel client

 drivers/gpu/drm/msm/msm_debugfs.c |   6 +-
 drivers/gpu/drm/msm/msm_drv.c     |  21 ++--
 drivers/gpu/drm/msm/msm_drv.h     |  12 ++-
 drivers/gpu/drm/msm/msm_fbdev.c   | 168 ++++++++++++++++++------------
 4 files changed, 118 insertions(+), 89 deletions(-)
Signature · 1 line
2.40.0