Skip to content

drm/{i915,xe}: Convert fbdev to DRM client

Thomas Zimmermann dri-devel intel-gfx intel-xe 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest6 patches 9 repliesIn review
  2. v76 patches 14 repliesSuperseded
  3. v67 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v57 patches13 repliesSuperseded
v2 posting 3/34 patches3 repliesSuperseded
v2 posting 2/38 patches9 repliesApplied
v2 posting 1/35 patches5 repliesSuperseded
v17 patches7 repliesApplied

Changes in v8 from the cover letter

- do setup and cleanup in intel_display_driver_{register,unregister}() (Jani, Jouni)
- mention xe in several commit messages (Rodrigo, Jani)
- resort patches to put driver-independent changes first
- slightly reword cover letter

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/client: Export drm_client_dev_unregister()drivers/gpu/drm/drm_client.c+13 -01 reply
2/6drm/i915: Move fbdev functionsdrivers/gpu/drm/i915/display/intel_fbdev.c+77 -770 replies
3/6drm/i915: Initialize fbdev DRM client with callback functionsdrivers/gpu/drm/i915/display/intel_fbdev.c+39 -40 replies
4/6drm/{i915,xe}: Unregister in-kernel clientsdrivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/xe/xe_device.c+4 -01 reply
5/6drm/{i915,xe}: Implement fbdev client callbacksdrivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/display/intel_fbdev.h +2 more+25 -490 replies
6/6drm/{i915, xe}: Implement fbdev emulation as in-kernel clientdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/display/intel_fbdev.c +2 more+80 -1406 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJouni HöganderLucas De Marchi
SeriesA-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/6] drm/{i915,xe}: Convert fbdev to DRM client

(was: drm/i915: Convert fbdev to DRM client)

Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. Also update the xe driver accordingly.

As with the other drivers' fbdev emulation, fbdev in i915 is now an in-kernel DRM client that runs after the DRM device has been registered. This allows to remove the asynchronous initialization.

i915 and xe are the final drivers with an fbdev emulation that is not build upon struct drm_client. Once reviewed, the patches would ideally go into drm-misc-next, so that the old fbdev helper code can be removed.

We can also attempt to add additional in-kernel clients. A DRM-based dmesg log or a bootsplash are commonly mentioned. DRM can then switch easily among the existing clients if/when required.

v8:
- do setup and cleanup in intel_display_driver_{register,unregister}() (Jani, Jouni)
- mention xe in several commit messages (Rodrigo, Jani)
- resort patches to put driver-independent changes first
- slightly reword cover letter

v7:
- update xe driver

v6:
- reorder patches to fix build (Jouni)
- remove unnecessary handling of non-atomic commits (Jouni, Ville)
- return errors from callbacks (Jouni)
- various minor fixes

v5:
- style fixes (checkpatch)

v4:
<no changes>

v3:
- support module unloading (Jani, CI bot)
- as before, silently ignore devices without displays (CI bot)

v2:
- fix error handling (Jani)
- fix non-fbdev builds
- various minor fixes and cleanups

Thomas Zimmermann (6):
drm/client: Export drm_client_dev_unregister() drm/i915: Move fbdev functions
drm/i915: Initialize fbdev DRM client with callback functions drm/{i915,xe}: Unregister in-kernel clients drm/{i915,xe}: Implement fbdev client callbacks drm/{i915,xe}: Implement fbdev emulation as in-kernel client

 drivers/gpu/drm/drm_client.c                  |  13 +
 drivers/gpu/drm/i915/display/intel_display.c  |   1 -
 .../drm/i915/display/intel_display_driver.c   |  24 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c    | 265 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_fbdev.h    |  29 +-
 drivers/gpu/drm/i915/i915_driver.c            |  22 --
 drivers/gpu/drm/xe/display/xe_display.c       |  11 -
 drivers/gpu/drm/xe/xe_device.c                |   1 +
 8 files changed, 167 insertions(+), 199 deletions(-)
Signature · 1 line
2.44.0