Skip to content

ice: allow matching on meta data

Michal Swiatkowski intel-wired-lan netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 11 repliesIn review
  2. v35 patches 4 repliesSuperseded
  3. v24 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches5 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ice: define meta data to match in switchdrivers/net/ethernet/intel/ice/ice_protocol_type.h drivers/net/ethernet/intel/ice/ice_switch.c drivers/net/ethernet/intel/ice/ice_vlan_mode.c+183 -162 replies
2/5ice: remove redundant Rx field from rule infodrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_switch.c drivers/net/ethernet/intel/ice/ice_switch.h +1 more+14 -222 replies
3/5ice: specify field names in ice_prot_ext initdrivers/net/ethernet/intel/ice/ice_switch.c+28 -233 replies
4/5ice: allow matching on meta datadrivers/net/ethernet/intel/ice/ice_protocol_type.h drivers/net/ethernet/intel/ice/ice_switch.c drivers/net/ethernet/intel/ice/ice_switch.h +2 more+95 -1052 replies
5/5ice: use src VSI instead of src MAC in slow-pathdrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_eswitch.h drivers/net/ethernet/intel/ice/ice_protocol_type.h +6 more+40 -1022 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPiotr RaczynskiSimon HormanLeon RomanovskySujai Buvaneswaran
1/5R-b R-b R-b T-b
2/5R-b R-b R-b T-b
3/5R-b R-b T-b
4/5R-b R-b R-b T-b
5/5R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH net-next v4 0/5] ice: allow matching on meta data

Hi,

This patchset is intended to improve the usability of the switchdev slow path. Without matching on a meta data values slow path works based on VF's MAC addresses. It causes a problem when the VF wants to use more than one MAC address (e.g. when it is in trusted mode).

Parse all meta data in the same place where protocol type fields are parsed. Add description for the currently implemented meta data. It is important to note that depending on DDP not all described meta data can be available. Using not available meta data leads to error returned by function which is looking for correct words in profiles read from DDP.

There is also one small improvement, remove of rx field in rule info structure (patch 2). It is redundant.

v3 --> v4: also based on Alexander comments; link [3]
* hole in ice_adv_rule_info {}, but logically segregate
* fix cosmetic tabs vs space etc.

v2 --> v3: based on Alexander Lobakin comments; link [2]
* add patch 4 to get rid of anonymous struct initialization
* few code style changes
* rename ice_is_rule_info_the_same() and add const params in it
* avoid holes in ice_adv_rule_info {}

v1 --> v2: link [1]
* fix spell issues
* use GENMASK to define source VSI mask

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/
[3] https://lore.kernel.org/netdev/[email protected]/
Michal Swiatkowski (5):
ice: define meta data to match in switch
ice: remove redundant Rx field from rule info
ice: specify field names in ice_prot_ext init
ice: allow matching on meta data
ice: use src VSI instead of src MAC in slow-path

 drivers/net/ethernet/intel/ice/ice_eswitch.c  |  84 ++-----
 drivers/net/ethernet/intel/ice/ice_eswitch.h  |  14 --
 .../ethernet/intel/ice/ice_protocol_type.h    | 197 ++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_repr.c     |  17 --
 drivers/net/ethernet/intel/ice/ice_repr.h     |   5 +-
 drivers/net/ethernet/intel/ice/ice_switch.c   | 232 ++++++++----------
 drivers/net/ethernet/intel/ice/ice_switch.h   |  13 +-
 drivers/net/ethernet/intel/ice/ice_tc_lib.c   |  34 ++-
 drivers/net/ethernet/intel/ice/ice_tc_lib.h   |   1 +
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |   3 -
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |   8 -
 .../net/ethernet/intel/ice/ice_vlan_mode.c    |   2 +-
 12 files changed, 351 insertions(+), 259 deletions(-)
Signature · 6 lines
2.39.2

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan