Skip to content

cgroup/cpuset: Fix CLONE_INTO_CGROUP problem & other issues

Waiman Long cgroups lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 6 repliesIn review
  2. v34 patches 0 repliesSuperseded
  3. v24 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches17 repliesSuperseded

Changes in v4 from the cover letter

- Add missing rcu_read_lock/unlock to cpuset_cancel_fork() in patch 3.
- Add patch 5 to reduce performance impact for the non-CLONE_INTO_CGROUP case.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach()kernel/cgroup/cpuset.c+5 -10 replies
2/5cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properlykernel/cgroup/cpuset.c+42 -200 replies
3/5cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methodskernel/cgroup/cpuset.c+86 -110 replies
4/5cgroup/cpuset: Make cpuset_attach_task() skip subpartitions CPUs for top_cpusetkernel/cgroup/cpuset.c+2 -10 replies
5/5cgroup/cpuset: Optimize out unneeded cpuset_can_fork/cpuset_cancel_fork callsinclude/linux/cgroup-defs.h kernel/cgroup/cgroup.c kernel/cgroup/cpuset.c+25 -54 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchMichal Koutný
1/5R-b
2/5
3/5
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] cgroup/cpuset: Fix CLONE_INTO_CGROUP problem & other issues

v4:
- Add missing rcu_read_lock/unlock to cpuset_cancel_fork() in patch 3.
- Add patch 5 to reduce performance impact for the non-CLONE_INTO_CGROUP case.

v3:
- Update patches 2 & 3 to put task_cs() call under rcu_read_lock().

v2:
- Drop v1 patch 3
- Add a new patch to fix an issue in cpuset_cancel_attach() and another patch to add cpuset_can_fork() and cpuset_cacnel_fork() methods.

The first patch in this series fixes a problem in cpuset_cancel_attach(). Patches 2 and 3 fixes the CLONE_INTO_CGROUP problem in cpuset. Patch 4 is a minor fix. The last patch is a performance optimization patch for the non-CLONE_INTO_CGROUP case.

Waiman Long (5):
cgroup/cpuset: Wake up cpuset_attach_wq tasks in
cpuset_cancel_attach()
cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods cgroup/cpuset: Make cpuset_attach_task() skip subpartitions CPUs for
top_cpuset
cgroup/cpuset: Optimize out unneeded
cpuset_can_fork/cpuset_cancel_fork calls

 include/linux/cgroup-defs.h |   6 ++
 kernel/cgroup/cgroup.c      |  23 +++--
 kernel/cgroup/cpuset.c      | 167 +++++++++++++++++++++++++++++-------
 3 files changed, 159 insertions(+), 37 deletions(-)
Signature · 1 line
2.31.1