Skip to content

ice: lower CPU usage with GNSS

Michal Schmidt intel-wired-lan netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 20 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Changed subject of patch 1. Requested by Andrew Lunn.
- Added patch 2 to change the polling interval as recommended by Intel.
- Added patch 3 to remove sq_cmd_timeout as suggested by Simon Horman.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ice: do not busy-wait to read GNSS datadrivers/net/ethernet/intel/ice/ice_gnss.c drivers/net/ethernet/intel/ice/ice_gnss.h+20 -253 replies
2/6ice: increase the GNSS data polling interval to 20 msdrivers/net/ethernet/intel/ice/ice_gnss.h+1 -13 replies
3/6ice: remove ice_ctl_q_info::sq_cmd_timeoutdrivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_controlq.c drivers/net/ethernet/intel/ice/ice_controlq.h+2 -63 replies
4/6ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUTdrivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_controlq.c drivers/net/ethernet/intel/ice/ice_controlq.h+13 -123 replies
5/6ice: remove unused buffer copy code in ice_sq_send_cmd_retry()drivers/net/ethernet/intel/ice/ice_common.c+2 -113 replies
6/6ice: sleep, don't busy-wait, in the SQ send retry loopdrivers/net/ethernet/intel/ice/ice_common.c+1 -13 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBrent RowsellArkadiusz KubalewskiSimon HormanSunitha Mekala
SeriesR-b T-b
1/6R-b R-b T-b
2/6R-b R-b T-b
3/6R-b R-b T-b
4/6T-b R-b R-b T-b
5/6R-b R-b T-b
6/6R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH net-next v2 0/6] ice: lower CPU usage with GNSS

This series lowers the CPU usage of the ice driver when using its provided /dev/gnss*.

v2:
- Changed subject of patch 1. Requested by Andrew Lunn.
- Added patch 2 to change the polling interval as recommended by Intel.
- Added patch 3 to remove sq_cmd_timeout as suggested by Simon Horman.

Michal Schmidt (6):
ice: do not busy-wait to read GNSS data
ice: increase the GNSS data polling interval to 20 ms
ice: remove ice_ctl_q_info::sq_cmd_timeout
ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT
ice: remove unused buffer copy code in ice_sq_send_cmd_retry()
ice: sleep, don't busy-wait, in the SQ send retry loop

 drivers/net/ethernet/intel/ice/ice_common.c   | 29 +++++--------
 drivers/net/ethernet/intel/ice/ice_controlq.c | 12 +++---
 drivers/net/ethernet/intel/ice/ice_controlq.h |  3 +-
 drivers/net/ethernet/intel/ice/ice_gnss.c     | 42 +++++++++----------
 drivers/net/ethernet/intel/ice/ice_gnss.h     |  3 +-
 5 files changed, 36 insertions(+), 53 deletions(-)
Signature · 6 lines
2.39.2

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan