Skip to content

t: fix unused files, part 2

Andrei Rybak git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 4 repliesIn review
  2. v26 patches 12 repliesSuperseded
  3. v16 patches 1 replySuperseded

Changes in v3 from the cover letter

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6t0300: don't create unused filet/t0300-credentials.sh+1 -10 replies
2/6t1300: fix config file syntax error descriptionst/t1300-config.sh+2 -20 replies
3/6t1300: don't create unused filest/t1300-config.sh+3 -30 replies
4/6t1450: don't create unused filest/t1450-fsck.sh+1 -40 replies
5/6t1502: don't create unused filest/t1502-rev-parse-parseopt.sh+3 -30 replies
6/6t2019: don't create unused filest/t2019-checkout-ambiguous-ref.sh+2 -20 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchØystein WalleElijah Newren
SeriesR-b
1/6
2/6
3/6
4/6
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] t: fix unused files, part 2

Creation of files from redirecting output of Git commands in tests has been removed for files which aren't being used for assertions. CC'ed are authors of the affected tests.

v1 cover letter:
https://lore.kernel.org/git/[email protected]/
v2 cover letter:
https://lore.kernel.org/git/[email protected]/

Changes since v2:

- Added "Acked-by" of Øystein Walle to patch 5/6
Cf. https://lore.kernel.org/git/CAFaJEqug4bghEMnEQzGDN10EqM8e8iSf5i12AvOm+NZzDCQKOw@mail.gmail.com/

Range diff:

1:  828bb18bd7 = 1:  828bb18bd7 t0300: don't create unused file
2:  a5b299a0c6 = 2:  a5b299a0c6 t1300: fix config file syntax error descriptions
3:  806df16415 = 3:  806df16415 t1300: don't create unused files
4:  6742c957e5 = 4:  6742c957e5 t1450: don't create unused files
5:  6c173a5c46 ! 5:  19ac488922 t1502: don't create unused files

@@ Commit message
Don't redirect standard output of "git rev-parse" to file "out" in t1502-rev-parse-parseopt.sh to avoid creating unnecessary files.

+ Acked-by: Øystein Walle <[email protected]>

## t/t1502-rev-parse-parseopt.sh ##
6: d508c1def3 = 6: c41657be88 t2019: don't create unused files

Andrei Rybak (6):
t0300: don't create unused file
t1300: fix config file syntax error descriptions
t1300: don't create unused files
t1450: don't create unused files
t1502: don't create unused files
t2019: don't create unused files

 t/t0300-credentials.sh            |  2 +-
 t/t1300-config.sh                 | 10 +++++-----
 t/t1450-fsck.sh                   |  5 +----
 t/t1502-rev-parse-parseopt.sh     |  6 +++---
 t/t2019-checkout-ambiguous-ref.sh |  4 ++--
 5 files changed, 12 insertions(+), 15 deletions(-)
Signature · 1 line
2.40.0