raw/ping: Fix locking in /proc/net/{raw,icmp}.
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | raw: Fix NULL deref in raw_get_next().include/ net/ net/ +1 more | +29 | 6 replies | Applied |
| 2/2 | ping: Fix potentail NULL deref for /proc/net/icmp.net/ | +4 | 1 reply | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Eric Dumazet |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 net 0/2] raw/ping: Fix locking in /proc/net/{raw,icmp}.
The first patch fixes a NULL deref for /proc/net/raw and second one fixes the same issue for ping sockets.
The first patch also converts hlist_nulls to hlist, but this is because the current code uses sk_nulls_for_each() for lockless readers, instead of sk_nulls_for_each_rcu() which adds memory barrier, but raw sockets does not use the nulls marker nor SLAB_TYPESAFE_BY_RCU in the first place.
OTOH, the ping sockets already uses sk_nulls_for_each_rcu(), and such conversion can be posted later for net-next.
Kuniyuki Iwashima (2):
raw: Fix NULL deref in raw_get_next(). ping: Fix potentail NULL deref for /proc/net/icmp.
include/net/raw.h | 4 ++-- net/ipv4/ping.c | 8 ++++---- net/ipv4/raw.c | 36 +++++++++++++++++++----------------- net/ipv4/raw_diag.c | 10 ++++------ net/ipv6/raw.c | 10 ++++------ 5 files changed, 33 insertions(+), 35 deletions(-)
Signature · 1 line
2.30.2