Skip to content

Add parents to struct pmu -> dev

Jonathan Cameron linux-arm-kernel linux-fpga lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 35 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32perf: Allow a PMU to have a parentinclude/linux/perf_event.h kernel/events/core.c+2 -014 replies
2/32perf/hisi-pcie: Assign parent for event_source devicedrivers/perf/hisilicon/hisi_pcie_pmu.c+1 -02 replies
3/32Documentation: hisi-pmu: Drop reference to /sys/devices pathDocumentation/admin-guide/perf/hisi-pmu.rst+0 -12 replies
4/32perf/hisi-uncore: Assign parents for event_source devicesdrivers/perf/hisilicon/hisi_uncore_pmu.c+1 -02 replies
5/32Documentation: hns-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/hns3-pmu.rst+4 -41 reply
6/32perf/hisi-hns3: Assign parents for event_source devicedrivers/perf/hisilicon/hns3_pmu.c+1 -00 replies
7/32perf/amlogic: Assign parents for event_source devicesdrivers/perf/amlogic/meson_ddr_pmu_core.c+1 -01 reply
8/32perf/arm_cspmu: Assign parents for event_source devicesdrivers/perf/arm_cspmu/arm_cspmu.c+1 -01 reply
9/32Documentation: xgene-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/xgene-pmu.rst+1 -10 replies
10/32perf/xgene: Assign parents for event_source devicesdrivers/perf/xgene_pmu.c+1 -00 replies
11/32Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/thunderx2-pmu.rst+1 -10 replies
12/32perf/thunderx2: Assign parents for event_source devicesdrivers/perf/thunderx2_pmu.c+1 -00 replies
13/32perf/riscv: Assign parents for event_source devicesdrivers/perf/riscv_pmu_legacy.c drivers/perf/riscv_pmu_sbi.c+2 -00 replies
14/32Documentation: qcom-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/qcom_l2_pmu.rst Documentation/admin-guide/perf/qcom_l3_pmu.rst+2 -20 replies
15/32perf/qcom: Assign parents for event_source devicesdrivers/perf/qcom_l2_pmu.c drivers/perf/qcom_l3_pmu.c+2 -00 replies
16/32perf/imx_ddr: Assign parents for event_source devicesdrivers/perf/fsl_imx8_ddr_perf.c+1 -00 replies
17/32perf/arm_pmu: Assign parents for event_source devicesdrivers/perf/arm_pmu_platform.c+1 -00 replies
18/32perf/alibaba_uncore: Assign parents for event_source devicedrivers/perf/alibaba_uncore_drw_pmu.c+1 -01 reply
19/32perf/arm-cci: Assign parents for event_source devicedrivers/perf/arm-cci.c+1 -01 reply
20/32perf/arm-ccn: Assign parents for event_source devicedrivers/perf/arm-ccn.c+1 -01 reply
21/32perf/arm-cmn: Assign parents for event_source devicedrivers/perf/arm-cmn.c+1 -01 reply
22/32perf/arm-dmc620: Assign parents for event_source devicedrivers/perf/arm_dmc620_pmu.c+1 -00 replies
23/32perf/arm-dsu: Assign parents for event_source devicedrivers/perf/arm_dsu_pmu.c+1 -01 reply
24/32perf/arm-smmuv3: Assign parents for event_source devicedrivers/perf/arm_smmuv3_pmu.c+1 -00 replies
25/32perf/arm-spe: Assign parents for event_source devicedrivers/perf/arm_spe_pmu.c+1 -01 reply
26/32arc: Assign parents for event_source devicesarch/arc/kernel/perf_event.c+1 -00 replies
27/32ARM: imx: Assign parents for mmdc event_source devicesarch/arm/mach-imx/mmdc.c+1 -00 replies
28/32dmaengine: idxd: Assign parent for event_source devicedrivers/dma/idxd/perfmon.c+1 -00 replies
29/32fpga: dfl: Assign parent for event_source devicedrivers/fpga/dfl-fme-perf.c+1 -01 reply
30/32drivers/nvdimm: Assign parent for event_source devicedrivers/nvdimm/nd_perf.c+1 -01 reply
31/32Documentation: ABI + trace: hisi_ptt: update paths to bus/event_sourceDocumentation/ABI/testing/sysfs-bus-event_source-devices-hisi_ptt Documentation/trace/hisi-ptt.rst MAINTAINERS+9 -91 reply
32/32hwtracing: hisi_ptt: Assign parent for event_source devicedrivers/hwtracing/ptt/hisi_ptt.c+1 -01 reply

Reviews trailers per patch

17 of 32 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan WilliamsGreg Kroah-HartmanSuzuki K PouloseShuai XueYicong YangXu YilunJiucheng XuRobin Murphy
SeriesR-b
1/32R-b R-b
2/32R-b R-b
3/32R-b R-b
4/32R-b R-b
5/32R-b
6/32
7/32R-b
8/32R-b
9/32
10/32
11/32
12/32
13/32
14/32
15/32
16/32
17/32
18/32R-b
19/32R-b
20/32A-b
21/32A-b
22/32
23/32R-b
24/32
25/32A-b
26/32
27/32
28/32
29/32R-b
30/32R-b
31/32R-b
32/32R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/32] Add parents to struct pmu -> dev

These are the low hanging fruit following GregKH's feedback that all the devices registered via perf_pmu_register() should have parents.

Note that this causes potential ABI breakage.

It may fall in the category of it isn't breakage if no one notices but I can't be certain of that. Whilst it is arguable that no one should be been accessing PMUs except via the event_source bus, there was documentation suggesting /sys/devices/ for particular PMUs (because it was a shorter path?)

The first patch is pulled out of the series:
https://lore.kernel.org/linux-cxl/[email protected]/
[PATCH v3 0/5] CXL 3.0 Performance Monitoring Unit support

In that particular case it is very useful to be able to figure out which CXL device the PMU device is associated with and looking at it's parents in the device model as shown with ls -lh /sys/bus/event_sources/devices/ is a very easy way to do this (once it is correctly parented).

Addressing all the other instances of struct pmu not covered by this series is likely to be a more complex discussion but unlikely to have an affect on what is proposed here.

Documentation updates deliberately 'fixed' in separate patches before changing the path to highlight that using /sys/bus/event_source/devices path is unchanged by this series and that is presumed to be the most common way these files are accessed.

Jonathan Cameron (32):
perf: Allow a PMU to have a parent
perf/hisi-pcie: Assign parent for event_source device
Documentation: hisi-pmu: Drop reference to /sys/devices path perf/hisi-uncore: Assign parents for event_source devices
Documentation: hns-pmu: Use /sys/bus/event_source/devices paths perf/hisi-hns3: Assign parents for event_source device perf/amlogic: Assign parents for event_source devices perf/arm_cspmu: Assign parents for event_source devices
Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths perf/xgene: Assign parents for event_source devices
Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths perf/thunderx2: Assign parents for event_source devices perf/riscv: Assign parents for event_source devices
Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths perf/qcom: Assign parents for event_source devices perf/imx_ddr: Assign parents for event_source devices perf/arm_pmu: Assign parents for event_source devices perf/alibaba_uncore: Assign parents for event_source device perf/arm-cci: Assign parents for event_source device perf/arm-ccn: Assign parents for event_source device perf/arm-cmn: Assign parents for event_source device perf/arm-dmc620: Assign parents for event_source device perf/arm-dsu: Assign parents for event_source device perf/arm-smmuv3: Assign parents for event_source device perf/arm-spe: Assign parents for event_source device
arc: Assign parents for event_source devices
ARM: imx: Assign parents for mmdc event_source devices
dmaengine: idxd: Assign parent for event_source device
fpga: dfl: Assign parent for event_source device drivers/nvdimm: Assign parent for event_source device
Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source
hwtracing: hisi_ptt: Assign parent for event_source device

 ...i_ptt => sysfs-bus-event_source-devices-hisi_ptt} | 12 ++++++------
 Documentation/admin-guide/perf/hisi-pmu.rst          |  1 -
 Documentation/admin-guide/perf/hns3-pmu.rst          |  8 ++++----
 Documentation/admin-guide/perf/qcom_l2_pmu.rst       |  2 +-
 Documentation/admin-guide/perf/qcom_l3_pmu.rst       |  2 +-
 Documentation/admin-guide/perf/thunderx2-pmu.rst     |  2 +-
 Documentation/admin-guide/perf/xgene-pmu.rst         |  2 +-
 Documentation/trace/hisi-ptt.rst                     |  4 ++--
 MAINTAINERS                                          |  2 +-
 arch/arc/kernel/perf_event.c                         |  1 +
 arch/arm/mach-imx/mmdc.c                             |  1 +
 drivers/dma/idxd/perfmon.c                           |  1 +
 drivers/fpga/dfl-fme-perf.c                          |  1 +
 drivers/hwtracing/ptt/hisi_ptt.c                     |  1 +
 drivers/nvdimm/nd_perf.c                             |  1 +
 drivers/perf/alibaba_uncore_drw_pmu.c                |  1 +
 drivers/perf/amlogic/meson_ddr_pmu_core.c            |  1 +
 drivers/perf/arm-cci.c                               |  1 +
 drivers/perf/arm-ccn.c                               |  1 +
 drivers/perf/arm-cmn.c                               |  1 +
 drivers/perf/arm_cspmu/arm_cspmu.c                   |  1 +
 drivers/perf/arm_dmc620_pmu.c                        |  1 +
 drivers/perf/arm_dsu_pmu.c                           |  1 +
 drivers/perf/arm_pmu_platform.c                      |  1 +
 drivers/perf/arm_smmuv3_pmu.c                        |  1 +
 drivers/perf/arm_spe_pmu.c                           |  1 +
 drivers/perf/fsl_imx8_ddr_perf.c                     |  1 +
 drivers/perf/hisilicon/hisi_pcie_pmu.c               |  1 +
 drivers/perf/hisilicon/hisi_uncore_pmu.c             |  1 +
 drivers/perf/hisilicon/hns3_pmu.c                    |  1 +
 drivers/perf/qcom_l2_pmu.c                           |  1 +
 drivers/perf/qcom_l3_pmu.c                           |  1 +
 drivers/perf/riscv_pmu_legacy.c                      |  1 +
 drivers/perf/riscv_pmu_sbi.c                         |  1 +
 drivers/perf/thunderx2_pmu.c                         |  1 +
 drivers/perf/xgene_pmu.c                             |  1 +
 include/linux/perf_event.h                           |  1 +
 kernel/events/core.c                                 |  1 +
 38 files changed, 46 insertions(+), 18 deletions(-)
 rename Documentation/ABI/testing/{sysfs-devices-hisi_ptt => sysfs-bus-event_source-devices-hisi_ptt} (83%)
Signature · 1 line
2.37.2