Skip to content

x86/access: CR0.WP=0/1 r/o tests

Sean Christopherson kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest9 patches 8 repliesIn review

Changes in v4 from the cover letter

- Make FEP manual-only, but included in the core loop.
- Mark the extra-slow (4+ minutes each in a VM) VPID-based variants manual-only
- Use the standard reporting machinery so that SKIPs show up correctly.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86: Use existing CR0.WP / CR4.SMEP bit definitionsx86/access.c x86/pks.c x86/pku.c+8 -130 replies
2/9x86/access: CR0.WP toggling write to r/o data testx86/access.c+58 -20 replies
3/9x86/access: Replace spaces with tabs in access_test.cx86/access_test.c+13 -130 replies
4/9x86/access: Use standard pass/fail reporting machineryx86/access.c x86/access.h x86/access_test.c+6 -80 replies
5/9x86/access: Add forced emulation supportx86/access.c x86/access.h x86/access_test.c +2 more+44 -123 replies
6/9x86/access: Try forced emulation for CR0.WP test as wellx86/access.c+7 -24 replies
7/9x86: Drop VPID invl tests from nested reduced MAXPHYADDR access testcasex86/unittests.cfg+1 -10 replies
8/9x86: Mark the VPID invalidation nested VMX access tests nodefaultx86/unittests.cfg+3 -30 replies
9/9nVMX: Add forced emulation variant of #PF access testx86/unittests.cfg x86/vmx_tests.c+26 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [kvm-unit-tests PATCH v4 0/9] x86/access: CR0.WP=0/1 r/o tests

Mathias' series to add explicit CR0.WP toggling tests, along with related cleanups from me to allow enabling forced emulation for the "core" of the access test.

The potentially controversial change is to make the extra-slow variants, including forced emulation, nodefault, i.e. so called "manual" testcases. Using nodefault is the most elegant solution I could find, e.g. makes it relatively simple to run all tests on bare metal without triggering a pile of timeouts when running in a VM.

v4:
- Make FEP manual-only, but included in the core loop.
- Mark the extra-slow (4+ minutes each in a VM) VPID-based variants manual-only
- Use the standard reporting machinery so that SKIPs show up correctly.

v3:
- https://lore.kernel.org/all/[email protected]
- Rewrite changelogs.
- Use helper for guts of CR0.WP test.

v2: https://lore.kernel.org/kvm/[email protected]

Mathias Krause (4):
x86: Use existing CR0.WP / CR4.SMEP bit definitions x86/access: CR0.WP toggling write to r/o data test x86/access: Add forced emulation support x86/access: Try forced emulation for CR0.WP test as well

Sean Christopherson (5):
x86/access: Replace spaces with tabs in access_test.c x86/access: Use standard pass/fail reporting machinery
x86: Drop VPID invl tests from nested reduced MAXPHYADDR access
testcase
x86: Mark the VPID invalidation nested VMX access tests nodefault
nVMX: Add forced emulation variant of #PF access test

 x86/access.c      | 114 +++++++++++++++++++++++++++++++++++++++-------
 x86/access.h      |   2 +-
 x86/access_test.c |  28 ++++++------
 x86/pks.c         |   5 +-
 x86/pku.c         |   5 +-
 x86/unittests.cfg |  20 ++++++--
 x86/vmx_tests.c   |  27 ++++++++---
 7 files changed, 154 insertions(+), 47 deletions(-)

base-commit: 5b5d27da2973b20ec29b18df4d749fb2190458af

Signature · 1 line
2.40.0.348.gf938b09366-goog