Skip to content

arch: Consolidate <asm/fb.h>

Thomas Zimmermann dri-devel linux-arch linux-arm-kernel linux-fbdev linux-ia64 linux-m68k linux-mips linux-parisc linux-sh linux-snps-arc linuxppc-dev lkml loongarch sparclinux 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest19 patches 15 repliesIn review
  2. v219 patches 10 repliesSuperseded
  3. v118 patches 6 repliesSuperseded

Changes in v3 from the cover letter

* use default fb_pgprotect() on arc, parisc, sparc64 (Arnd)
* fix includes in generic fb.h

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19fbdev: Prepare generic architecture helpersinclude/asm-generic/fb.h+22 -20 replies
2/19arch/arc: Implement <asm/fb.h> with generic helpersarch/arc/include/asm/fb.h+2 -140 replies
3/19arch/arm: Implement <asm/fb.h> with generic helpersarch/arm/include/asm/fb.h+1 -140 replies
4/19arch/arm64: Implement <asm/fb.h> with generic helpersarch/arm64/include/asm/fb.h+1 -140 replies
5/19arch/ia64: Implement <asm/fb.h> with generic helpersarch/ia64/include/asm/fb.h+5 -60 replies
6/19arch/loongarch: Implement <asm/fb.h> with generic helpersarch/loongarch/include/asm/fb.h+1 -141 reply
7/19arch/m68k: Merge variants of fb_pgprotect() into single functionarch/m68k/include/asm/fb.h+3 -90 replies
8/19arch/m68k: Implement <asm/fb.h> with generic helpersarch/m68k/include/asm/fb.h+4 -60 replies
9/19arch/mips: Implement <asm/fb.h> with generic helpersarch/mips/include/asm/fb.h+4 -60 replies
10/19video: Remove trailing whitespacesdrivers/video/console/sticon.c drivers/video/console/sticore.c drivers/video/fbdev/sticore.h +1 more+138 -1380 replies
11/19video: Move HP PARISC STI core code to shared locationdrivers/video/Kconfig drivers/video/Makefile drivers/video/console/Kconfig +6 more+14 -80 replies
12/19arch/parisc: Remove trailing whitespacesarch/parisc/Makefile+1 -10 replies
13/19arch/parisc: Implement fb_is_primary_device() under arch/pariscarch/parisc/Makefile arch/parisc/include/asm/fb.h arch/parisc/video/Makefile +3 more+35 -200 replies
14/19arch/parisc: Implement <asm/fb.h> with generic helpersarch/parisc/include/asm/fb.h+4 -140 replies
15/19arch/powerpc: Implement <asm/fb.h> with generic helpersarch/powerpc/include/asm/fb.h+3 -50 replies
16/19arch/sh: Implement <asm/fb.h> with generic helpersarch/sh/include/asm/fb.h+1 -146 replies
17/19arch/sparc: Implement fb_is_primary_device() in source filearch/sparc/Makefile arch/sparc/include/asm/fb.h arch/sparc/video/Makefile +1 more+33 -185 replies
18/19arch/sparc: Implement <asm/fb.h> with generic helpersarch/sparc/include/asm/fb.h+8 -80 replies
19/19arch/x86: Implement <asm/fb.h> with generic helpersarch/x86/include/asm/fb.h+8 -30 replies

Reviews trailers per patch

6 of 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArnd BergmannGeert UytterhoevenMichael EllermanJohn Paul Adrian GlaubitzHelge DellerWANG Xuerui
SeriesA-b A-b
1/19A-b
2/19
3/19
4/19
5/19
6/19R-b
7/19R-b A-b
8/19A-b
9/19
10/19
11/19
12/19
13/19
14/19
15/19A-b
16/19A-b
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/19] arch: Consolidate <asm/fb.h>

Various architectures provide <asm/fb.h> with helpers for fbdev framebuffer devices. Share the contained code where possible. There is already <asm-generic/fb.h>, which implements generic (as in 'empty') functions of the fbdev helpers. The header was added in commit aafe4dbed0bf ("asm-generic: add generic versions of common headers"), but never used.

Each per-architecture header file declares and/or implements fbdev helpers and defines a preprocessor token for each. The generic header then provides the remaining helpers. It works like the I/O helpers in <asm/io.h>.

For PARISC, the architecture helpers are mixed up with helpers for the system's STI graphics firmware. We first move the STI code to appropriate locations under video/ and then move the architecture helper under arch/parisc.

For Sparc, there's an additional patch that moves the implementation from the header into a source file. This allows to avoid some include statements in the header file.

Built on arm, arm64, m68k, mips, parisc, powerpc, sparc and x86.

v3:
* use default fb_pgprotect() on arc, parisc, sparc64 (Arnd)
* fix includes in generic fb.h
v2:
* make writecombine the default mapping mode (Arnd)
* rework fb_pgprotect() on m68k

Thomas Zimmermann (19):
fbdev: Prepare generic architecture helpers
arch/arc: Implement <asm/fb.h> with generic helpers arch/arm: Implement <asm/fb.h> with generic helpers arch/arm64: Implement <asm/fb.h> with generic helpers arch/ia64: Implement <asm/fb.h> with generic helpers arch/loongarch: Implement <asm/fb.h> with generic helpers arch/m68k: Merge variants of fb_pgprotect() into single function arch/m68k: Implement <asm/fb.h> with generic helpers arch/mips: Implement <asm/fb.h> with generic helpers
video: Remove trailing whitespaces
video: Move HP PARISC STI core code to shared location arch/parisc: Remove trailing whitespaces
arch/parisc: Implement fb_is_primary_device() under arch/parisc arch/parisc: Implement <asm/fb.h> with generic helpers arch/powerpc: Implement <asm/fb.h> with generic helpers arch/sh: Implement <asm/fb.h> with generic helpers arch/sparc: Implement fb_is_primary_device() in source file arch/sparc: Implement <asm/fb.h> with generic helpers arch/x86: Implement <asm/fb.h> with generic helpers

 arch/arc/include/asm/fb.h                     |  16 +-
 arch/arm/include/asm/fb.h                     |  15 +-
 arch/arm64/include/asm/fb.h                   |  15 +-
 arch/ia64/include/asm/fb.h                    |  11 +-
 arch/loongarch/include/asm/fb.h               |  15 +-
 arch/m68k/include/asm/fb.h                    |  22 +--
 arch/mips/include/asm/fb.h                    |  10 +-
 arch/parisc/Makefile                          |   4 +-
 arch/parisc/include/asm/fb.h                  |  20 +--
 arch/parisc/video/Makefile                    |   3 +
 arch/parisc/video/fbdev.c                     |  27 +++
 arch/powerpc/include/asm/fb.h                 |   8 +-
 arch/sh/include/asm/fb.h                      |  15 +-
 arch/sparc/Makefile                           |   1 +
 arch/sparc/include/asm/fb.h                   |  33 ++--
 arch/sparc/video/Makefile                     |   3 +
 arch/sparc/video/fbdev.c                      |  24 +++
 arch/x86/include/asm/fb.h                     |  11 +-
 drivers/video/Kconfig                         |   7 +
 drivers/video/Makefile                        |   1 +
 drivers/video/console/Kconfig                 |   1 +
 drivers/video/console/Makefile                |   4 +-
 drivers/video/console/sticon.c                |   6 +-
 drivers/video/fbdev/Kconfig                   |   3 +-
 drivers/video/fbdev/stifb.c                   | 158 +++++++++---------
 drivers/video/{console => }/sticore.c         | 123 ++++++--------
 include/asm-generic/fb.h                      |  24 ++-
 .../video/fbdev => include/video}/sticore.h   |  16 +-
 28 files changed, 285 insertions(+), 311 deletions(-)
 create mode 100644 arch/parisc/video/Makefile
 create mode 100644 arch/parisc/video/fbdev.c
 create mode 100644 arch/sparc/video/Makefile
 create mode 100644 arch/sparc/video/fbdev.c
 rename drivers/video/{console => }/sticore.c (95%)
 rename {drivers/video/fbdev => include/video}/sticore.h (99%)

base-commit: c7cfe0c7215db9556ffe7ce33d1f60f768336cfd
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36

Signature · 1 line
2.40.0