Skip to content

modules/kmod: replace implementation with a sempahore

Luis Chamberlain linux-mm linux-modules linux-patches lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 3 repliesSuperseded
  3. v22 patches 9 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Change DEFINE_SEMAPHORE() to take a number argumentarch/mips/cavium-octeon/setup.c arch/x86/kernel/cpu/intel.c drivers/firmware/efi/runtime-wrappers.c +9 more+20 -160 replies
2/2modules/kmod: replace implementation with a semaphorekernel/module/kmod.c+7 -190 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSergey SenozhatskyDavidlohr BuesoMiroslav BenesDavid Hildenbrand
1/2R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/2] modules/kmod: replace implementation with a sempahore

Changes on this v4:

o Really add Matthew Wilcox' preferred tribal knowledge docs
o Add all the pending tags

Changes on v3:

o Tons of spell checks thanks to Miroslav Benes
o Fixed a stupid bug where I was using the timeout without HZ as reported by Miroslav Benes
o Enanced the tribal knowledge docs for the semaphore Vs mutex considerations folks might make as suggested by Matthew Wilcox
o Added tags for patches

Changes on v2:
o split the series up into its own
o adopt Peter's patch and extend it with some documentation as to why some folks stick to binary semaphores over mutexes
o modify kmod.c to use the preferred declaration

Luis Chamberlain (1):
modules/kmod: replace implementation with a semaphore

Peter Zijlstra (1):
Change DEFINE_SEMAPHORE() to take a number argument

 arch/mips/cavium-octeon/setup.c               |  2 +-
 arch/x86/kernel/cpu/intel.c                   |  2 +-
 drivers/firmware/efi/runtime-wrappers.c       |  2 +-
 drivers/firmware/efi/vars.c                   |  2 +-
 drivers/macintosh/adb.c                       |  2 +-
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  2 +-
 drivers/platform/x86/intel/ifs/sysfs.c        |  2 +-
 drivers/scsi/esas2r/esas2r_ioctl.c            |  2 +-
 .../interface/vchiq_arm/vchiq_arm.c           |  2 +-
 include/linux/semaphore.h                     | 10 +++++--
 kernel/module/kmod.c                          | 26 +++++--------------
 kernel/printk/printk.c                        |  2 +-
 net/rxrpc/call_object.c                       |  6 ++---
 13 files changed, 27 insertions(+), 35 deletions(-)
Signature · 1 line
2.39.2