Skip to content

video/aperture: Ignore firmware framebuffers with non-primary devices

Thomas Zimmermann dri-devel linux-amlogic linux-arm-kernel linux-fbdev linux-hyperv linux-pci linux-tegra stable 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest9 patches 5 repliesIn review
  2. v49 patches 4 repliesSuperseded

Changes in v5 from the cover letter

* fix gma500 comment
* add S-o-b tag with Daniel's Intel address

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffersdrivers/gpu/drm/gma500/psb_drv.c+7 -21 reply
2/9video/aperture: use generic code to figure out the vga default devicedrivers/video/aperture.c+2 -34 replies
3/9drm/aperture: Remove primary argumentdrivers/gpu/drm/arm/hdlcd_drv.c drivers/gpu/drm/armada/armada_drv.c drivers/gpu/drm/drm_aperture.c +10 more+16 -230 replies
4/9video/aperture: Only kick vgacon when the pdev is decoding vgadrivers/video/aperture.c+9 -70 replies
5/9video/aperture: Move vga handling to pci functiondrivers/video/aperture.c+7 -80 replies
6/9video/aperture: Drop primary argumentdrivers/gpu/drm/drm_aperture.c drivers/video/aperture.c drivers/video/fbdev/hyperv_fb.c +1 more+9 -110 replies
7/9video/aperture: Only remove sysfb on the default vga pci devicedrivers/video/aperture.c+4 -30 replies
8/9fbdev: Simplify fb_is_primary_device for x86arch/x86/video/fbdev.c+1 -120 replies
9/9video/aperture: Provide a VGA helper for gma500 and internal usedrivers/gpu/drm/gma500/psb_drv.c drivers/video/aperture.c include/linux/aperture.h+81 -320 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchMartin BlumenstinglThierry RedingJavier Martinez CanillasAaron Plattner
1/9R-b
2/9R-b
3/9A-b A-b R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b T-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/9] video/aperture: Ignore firmware framebuffers with non-primary devices

Only remove sysfb and VGA devices for primary graphics devices. The PCI helper for aperture ownership now detects primary devices. Resolves bug reports about lost framebuffer consoles on systems with multiple graphics cards.

The series picks up Daniel's patchset at v3 from [1] and cleans up a few minor things. There's another patch on top that clarifys gma500's special case.

v5:
* fix gma500 comment
* add S-o-b tag with Daniel's Intel address
v4:
* add gma500 patch on top of v3
* fix Daniel's S-o-b address
* fix various typos in the commit messages

Daniel Vetter (8):
drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers video/aperture: use generic code to figure out the vga default device drm/aperture: Remove primary argument
video/aperture: Only kick vgacon when the pdev is decoding vga video/aperture: Move vga handling to pci function video/aperture: Drop primary argument
video/aperture: Only remove sysfb on the default vga pci device
fbdev: Simplify fb_is_primary_device for x86

Thomas Zimmermann (1):
video/aperture: Provide a VGA helper for gma500 and internal use

 arch/x86/video/fbdev.c                      | 13 +---
 drivers/gpu/drm/arm/hdlcd_drv.c             |  2 +-
 drivers/gpu/drm/armada/armada_drv.c         |  2 +-
 drivers/gpu/drm/drm_aperture.c              | 11 +---
 drivers/gpu/drm/gma500/psb_drv.c            | 43 ++++++++++---
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c     |  1 -
 drivers/gpu/drm/meson/meson_drv.c           |  2 +-
 drivers/gpu/drm/msm/msm_fbdev.c             |  2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c |  2 +-
 drivers/gpu/drm/stm/drv.c                   |  2 +-
 drivers/gpu/drm/sun4i/sun4i_drv.c           |  2 +-
 drivers/gpu/drm/tegra/drm.c                 |  2 +-
 drivers/gpu/drm/vc4/vc4_drv.c               |  2 +-
 drivers/video/aperture.c                    | 70 ++++++++++++++-------
 drivers/video/fbdev/hyperv_fb.c             |  2 +-
 include/drm/drm_aperture.h                  |  7 +--
 include/linux/aperture.h                    | 16 +++--
 17 files changed, 108 insertions(+), 73 deletions(-)
Signature · 1 line
2.40.0