Skip to content

Improvements to GuC error capture

[email protected] dri-devel intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v15 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/guc: Don't capture Gen8 regs on Xe devicesdrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c+5 -20 replies
2/4drm/i915/guc: Consolidate duplicated capture list codedrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c+29 -830 replies
3/4drm/i915/guc: Capture list naming clean updrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c+49 -511 reply
4/4drm/i915/guc: Fix error capture for virtual enginesdrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c drivers/gpu/drm/i915/gt/uc/intel_guc_capture.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+70 -70 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAlan Previn
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Improvements to GuC error capture

From: John Harrison <[email protected]>

The GuC error capture list creation was including Gen8 registers on Xe platforms. While fixing that, it was noticed that there were other issues. The platform naming was wrong, the naming of lists was misleading, the steered register code was duplicated and steered registers were not included on all supported platforms.

Separately, it was noticed that the capture list search was broken for virtual engines. So fix that up too.

v2: Swuash the split patches into a single patch ready for merge. Also include an extra patch about capture lists and virtual engines.

John Harrison (4):
drm/i915/guc: Don't capture Gen8 regs on Xe devices drm/i915/guc: Consolidate duplicated capture list code drm/i915/guc: Capture list naming clean up drm/i915/guc: Fix error capture for virtual engines

 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 242 ++++++++----------
 .../gpu/drm/i915/gt/uc/intel_guc_capture.h    |   3 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  32 ++-
 drivers/gpu/drm/i915/i915_gpu_error.c         |  11 +-
 4 files changed, 149 insertions(+), 139 deletions(-)
Signature · 1 line
2.39.1