Skip to content

Submit zoned writes in order

Bart Van Assche dm-devel linux-block 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 16 repliesIn review
  2. v37 patches 30 repliesSuperseded
  3. v212 patches 28 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Dropped the changes for sending already dispatched requests back to the I/O scheduler if the block driver is busy.
- Dropped several patches that aren't needed to preserve the order of zoned writes.
- Only send requeued writes to the I/O scheduler. Send requeued reads straight to the dispatch queue.
- Changed the approach from one requeue list per request queue into one requeue list per hardware queue.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block: Rename a local variable in blk_mq_requeue_work()block/blk-mq.c+4 -41 reply
2/7block: Simplify blk_mq_requeue_work()block/blk-mq.c+3 -52 replies
3/7block: Send requeued requests to the I/O schedulerblock/blk-mq.c include/linux/blk-mq.h+7 -73 replies
4/7block: One requeue list per hctxblock/blk-flush.c block/blk-mq-debugfs.c block/blk-mq.c +2 more+83 -694 replies
5/7block: Preserve the order of requeued requestsblock/blk-mq.c include/linux/blk-mq.h+9 -234 replies
6/7dm: Inline __dm_mq_kick_requeue_list()drivers/md/dm-rq.c+2 -70 replies
7/7block: Inline blk_mq_{,delay_}kick_requeue_list()block/blk-flush.c block/blk-mq-debugfs.c block/blk-mq.c +7 more+13 -292 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigJohannes ThumshirnVineeth VijayanDamien Le MoalRoger Pau Monné
1/7R-b R-b R-b
2/7R-b R-b
3/7
4/7R-b
5/7
6/7R-b
7/7A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/7] Submit zoned writes in order

Hi Jens,

Tests with a zoned UFS prototype have shown that the block layer may reorder zoned writes (REQ_OP_WRITE). The UFS driver is more likely to trigger reordering than other SCSI drivers because it reports BLK_STS_DEV_RESOURCE more often, e.g. during clock scaling. This patch series makes sure that zoned writes are submitted in order without affecting other workloads significantly.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v3:
- Dropped the changes for sending already dispatched requests back to the I/O scheduler if the block driver is busy.
- Dropped several patches that aren't needed to preserve the order of zoned writes.
- Only send requeued writes to the I/O scheduler. Send requeued reads straight to the dispatch queue.
- Changed the approach from one requeue list per request queue into one requeue list per hardware queue.

Changes compared to v2:
- Changed the approach from one requeue list per hctx into preserving one requeue list per request queue.
- Rebased on top of Jens' for-next branch. Left out the mq-deadline patches since these are already in the for-next branch.
- Modified patch "block: Requeue requests if a CPU is unplugged" such that it always uses the requeue list.
- Added a patch that removes blk_mq_kick_requeue_list() and blk_mq_delay_kick_requeue_list().
- Dropped patch "block: mq-deadline: Disable head insertion for zoned writes".
- Dropped patch "block: mq-deadline: Introduce a local variable".

Changes compared to v1:
- Fixed two issues detected by the kernel test robot.

Bart Van Assche (7):
block: Rename a local variable in blk_mq_requeue_work()
block: Simplify blk_mq_requeue_work()
block: Send requeued requests to the I/O scheduler
block: One requeue list per hctx
block: Preserve the order of requeued requests
dm: Inline __dm_mq_kick_requeue_list()
block: Inline blk_mq_{,delay_}kick_requeue_list()

 block/blk-flush.c            | 28 +++++++------
 block/blk-mq-debugfs.c       | 66 ++++++++++++++---------------
 block/blk-mq.c               | 81 ++++++++++++++----------------------
 drivers/block/ublk_drv.c     |  6 +--
 drivers/block/xen-blkfront.c |  1 -
 drivers/md/dm-rq.c           | 11 ++---
 drivers/nvme/host/core.c     |  2 +-
 drivers/s390/block/scm_blk.c |  2 +-
 drivers/scsi/scsi_lib.c      |  2 +-
 include/linux/blk-mq.h       | 11 +++--
 include/linux/blkdev.h       |  5 ---
 11 files changed, 96 insertions(+), 119 deletions(-)