Skip to content

nvme io_uring_cmd polling enhancements

Keith Busch io-uring linux-block linux-nvme oe-kbuild-all oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block: add request polling helperblock/blk-mq.c include/linux/blk-mq.h+20 -00 replies
2/5nvme: simplify passthrough bio cleanupdrivers/nvme/host/ioctl.c+9 -172 replies
3/5nvme: unify nvme request end_iodrivers/nvme/host/ioctl.c+9 -481 reply
4/5nvme: use blk-mq polling for uring commandsdrivers/nvme/host/ioctl.c drivers/nvme/host/multipath.c drivers/nvme/host/nvme.h+9 -530 replies
5/5io_uring: remove uring_cmd cookieinclude/linux/io_uring.h io_uring/uring_cmd.c+2 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/5] nvme io_uring_cmd polling enhancements

From: Keith Busch <[email protected]>

Similar idea as the original v1, but even better.

This series originally aimed at improve polling without payloads, and fix a potential bug when polling multipath. This ended up significantly simplifying the nvme uring_cmd handling in the process.

In order to ensure we're polling the correct thing, we need the original request, but we can't depend on the "cookie" since the field has multi-purpose. But we have a free spot for the request in the driver's "pdu", so the driver just needs to detangle the "bio" occupying the same spot.

Keith Busch (5):
block: add request polling helper
nvme: simplify passthrough bio cleanup
nvme: unify nvme request end_io
nvme: use blk-mq polling for uring commands
io_uring: remove uring_cmd cookie

 block/blk-mq.c                |  18 +++++
 drivers/nvme/host/ioctl.c     | 137 ++++++----------------------------
 drivers/nvme/host/multipath.c |   2 +-
 drivers/nvme/host/nvme.h      |   2 -
 include/linux/blk-mq.h        |   2 +
 include/linux/io_uring.h      |   8 +-
 io_uring/uring_cmd.c          |   1 -
 7 files changed, 47 insertions(+), 123 deletions(-)
Signature · 1 line
2.34.1