Skip to content

ipvs: Cleanups for v6.4

Simon Horman lkml lvs-devel netdev netfilter-devel 3 versions – Applied

Status from this message: Applied, sorry Julian, I missed your Acked-by: tag.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesApplied
  2. v24 patches 4 repliesSuperseded
  3. v14 patches 1 replySuperseded

Changes in v3 from the cover letter

- Patch 2/4: Correct division by 1024.
It was applied to the wrong variable in v2.
- Add Horatiu's Reviewed-by tag.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4ipvs: Update width of source for ip_vs_sync_conn_optionsinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_sync.c+5 -30 replies
2/4ipvs: Consistently use array_size() in ip_vs_conn_init()net/netfilter/ipvs/ip_vs_conn.c+6 -60 replies
3/4ipvs: Remove {Enter,Leave}Functioninclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_core.c net/netfilter/ipvs/ip_vs_ctl.c +2 more+9 -1120 replies
4/4ipvs: Correct spelling in commentsinclude/net/ip_vs.h+3 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHoratiu VulturJulian Anastasov
SeriesA-b
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4

Hi Julian,

this series aims to clean up IPVS in several ways without implementing any functional changes, aside from removing some debugging output.

Patch 1/4: Update width of source for ip_vs_sync_conn_options
The operation is safe, use an annotation to describe it properly.

Patch 2/4: Consistently use array_size() in ip_vs_conn_init()
It seems better to use helpers consistently.

Patch 3/4: Remove {Enter,Leave}Function
These seem to be well past their use-by date.

Patch 4/4: Correct spelling in comments
I can't spell. But codespell helps me these days.

All changes: compile tested only!

---
Changes in v3:
- Patch 2/4: Correct division by 1024.
It was applied to the wrong variable in v2.
- Add Horatiu's Reviewed-by tag.

Changes in v2:
- Patch 1/4: Correct spelling of 'conn' in subject.
- Patch 2/4: Restore division by 1024. It was lost on v1.

---
Simon Horman (4):
ipvs: Update width of source for ip_vs_sync_conn_options
ipvs: Consistently use array_size() in ip_vs_conn_init()
ipvs: Remove {Enter,Leave}Function
ipvs: Correct spelling in comments

 include/net/ip_vs.h             | 32 +++++----------------
 net/netfilter/ipvs/ip_vs_conn.c | 12 ++++----
 net/netfilter/ipvs/ip_vs_core.c |  8 ------
 net/netfilter/ipvs/ip_vs_ctl.c  | 26 +----------------
 net/netfilter/ipvs/ip_vs_sync.c |  7 +----
 net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++-----------------------------------
 6 files changed, 23 insertions(+), 124 deletions(-)

base-commit: 99676a5766412f3936c55b9d18565d248e5463ee