Skip to content

Meteorlake interrupt & TLB handling updates

Matt Roper intel-xe 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 16 repliesIn review
  2. v16 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/xe/irq: Cleanup media GT interrupt flowdrivers/gpu/drm/xe/xe_irq.c+65 -143 replies
2/8drm/xe/irq: Improve warnings and assertions for GT handlingdrivers/gpu/drm/xe/xe_irq.c+19 -101 reply
3/8drm/xe/irq: Process Gunit interrupts in relation to the devicedrivers/gpu/drm/xe/xe_irq.c+4 -31 reply
4/8drm/xe: Fix xe_mmio_rmw32 operationdrivers/gpu/drm/xe/xe_mmio.h+1 -13 replies
5/8drm/xe/irq: Ensure primary GuC won't clobber media GuC's interrupt maskdrivers/gpu/drm/xe/xe_guc.c+7 -41 reply
6/8drm/xe: Include GT ID in error message if TLB invalidation times outdrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+2 -22 replies
7/8drm/xe: Invalidate TLB on all affected GTs during GGTT updatesdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_ggtt_types.h drivers/gpu/drm/xe/xe_gt.c +1 more+18 -52 replies
8/8drm/xe/tlb: Obtain forcewake when doing GGTT TLB invalidationsdrivers/gpu/drm/xe/xe_ggtt.c+9 -01 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchLucas De MarchiAndi Shyti
1/8R-b
2/8
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-xe] [PATCH v2 0/8] Meteorlake interrupt & TLB handling updates

Although Meteor Lake has multiple GTs, we need to be careful not to use multi-tile flows when processing interrupts. The platform as a whole only has a single copy of the SGunit interrupt registers, and interrupts relating to the media GT are delivered as part of the primary GT's IRQ reporting flow. Only when an engine (or GuC) interrupt is raised do we need to determine which GT it relates to for further processing.

The whole multi-GT vs multi-tile situation is made more confusing by the Xe driver's misuse of 'gt' as the target of all register operations. That's probably something we should refactor in the future so that xe_mmio_*() will take something more appropriate than an xe_gt parameter.

With the fixes in this series, interrupts are now properly flowing on both the primary and media GT for MTL. We're still seeing some TLB invalidation timeouts, but those no longer seem to be caused by problems with interrupt handling.

Matt Roper (8):
drm/xe/irq: Cleanup media GT interrupt flow
drm/xe/irq: Improve warnings and assertions for GT handling drm/xe/irq: Process Gunit interrupts in relation to the device drm/xe: Fix xe_mmio_rmw32 operation
drm/xe/irq: Ensure primary GuC won't clobber media GuC's interrupt
mask
drm/xe: Include GT ID in error message if TLB invalidation times out drm/xe: Invalidate TLB on all affected GTs during GGTT updates drm/xe/tlb: Obtain forcewake when doing GGTT TLB invalidations

 drivers/gpu/drm/xe/xe_ggtt.c                |  24 +++-
 drivers/gpu/drm/xe/xe_ggtt_types.h          |   2 +-
 drivers/gpu/drm/xe/xe_gt.c                  |   4 +
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |   4 +-
 drivers/gpu/drm/xe/xe_gt_types.h            |   2 +
 drivers/gpu/drm/xe/xe_guc.c                 |  11 +-
 drivers/gpu/drm/xe/xe_irq.c                 | 115 +++++++++++++++-----
 drivers/gpu/drm/xe/xe_mmio.h                |   2 +-
 8 files changed, 125 insertions(+), 39 deletions(-)
Signature · 1 line
2.39.2