Skip to content

mm/hugetlb: More fixes around uffd-wp vs fork() / RO pins

Peter Xu linux-mm lkml stable 2 versions – Applied

Status from this message: [merged mm-stable] selftests-mm-add-tests-for-ro-pinning-vs-fork.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied 6/6
  2. v16 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Added R-bs
- Fix patch 1 issue on hugetlb swap entry [Mika]

Patches in v2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6mm/hugetlb: Fix uffd-wp during fork()mm/hugetlb.c+15 -90 repliesApplied
2/6mm/hugetlb: Fix uffd-wp bit lost when unsharing happensmm/hugetlb.c+5 -22 repliesApplied
3/6selftests/mm: Add a few options for uffd-unit-testtools/testing/selftests/mm/uffd-unit-tests.c+45 -71 replyApplied
4/6selftests/mm: Extend and rename uffd pagemap testtools/testing/selftests/mm/uffd-unit-tests.c+106 -240 repliesApplied
5/6selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBStools/testing/selftests/mm/Makefile tools/testing/selftests/mm/check_config.sh+6 -60 repliesApplied
6/6selftests/mm: Add tests for RO pinning vs fork()tools/testing/selftests/mm/uffd-unit-tests.c+141 -30 repliesApplied

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchDavid HildenbrandMike Kravetz
1/6R-b
2/6R-b R-b
3/6R-b
4/6
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] mm/hugetlb: More fixes around uffd-wp vs fork() / RO pins

v2:
- Added R-bs
- Fix patch 1 issue on hugetlb swap entry [Mika]

This is a follow up of previous discussion here:

https://lore.kernel.org/r/20230324222707.GA3046@monkey

There, Mike correctly pointed out that uffd-wp bit can get lost too when Copy-On-Read triggers. Last time we didn't have a reproducer, I finally wrote a reproducer and attached as the last patch.

When at it, I decided to also add some more uffd-wp tests against fork(), and I found more bugs. None of them were reported by anyone probably because none of us cares, but since they're still bugs and can be reproduced by the unit test I fixed them too in another patch.

The initial patch 1-2 are fixes to bugs, copied stable.

The rest patches 3-6 introduces unit tests to verify (based on the recent rework on uffd unit test). Note that not all the bugfixes in patch 1 is verified (e.g. on changes to hugetlb hwpoison / migration entries), but I assume they can be reviewed with careful eyes.

Thanks,

Peter Xu (6):
mm/hugetlb: Fix uffd-wp during fork() mm/hugetlb: Fix uffd-wp bit lost when unsharing happens selftests/mm: Add a few options for uffd-unit-test selftests/mm: Extend and rename uffd pagemap test selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS selftests/mm: Add tests for RO pinning vs fork()

 mm/hugetlb.c                                 |  31 +-
 tools/testing/selftests/mm/Makefile          |   8 +-
 tools/testing/selftests/mm/check_config.sh   |   4 +-
 tools/testing/selftests/mm/uffd-unit-tests.c | 318 +++++++++++++++++--
 4 files changed, 314 insertions(+), 47 deletions(-)
Signature · 1 line
2.39.1