lib/percpu_counter, cpu/hotplug: Cure the cpu_dying_mask woes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | lib/percpu_counter: Fix CPU hotplug handlinginclude/ lib/ | +26 | 3 replies | |
| 2/3 | cpu/hotplug: Remove export of cpu_active_mask and cpu_dying_maskkernel/ | +0 | 0 replies | |
| 3/3 | cpu/hotplug: Get rid of cpu_dying_maskinclude/ kernel/ kernel/ +1 more | +41 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dennis Zhou | Valentin Schneider |
|---|---|---|
| Series | R-b | |
| 1/3 | A-b | |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch 0/3] lib/percpu_counter, cpu/hotplug: Cure the cpu_dying_mask woes
Hi!
The cpu_dying_mask is not only undocumented but also to some extent a misnomer. It's purpose is to capture the last direction of a cpu_up() or cpu_down() operation taking eventual rollback operations into account.
cpu_dying mask is not really useful for general consumption. The cpu_dying_mask bits are sticky even after cpu_up() or cpu_down() completes.
A recent fix to plug a race in the per CPU counter code picked cpu_dying_mask to cure it. Unfortunately this does not work as the author probably expected and the behaviour of cpu_dying_mask is not easy to change without breaking the only other and initial user, the scheduler.
This series addresses this by:
1) Reworking the per CPU counter hotplug mechanism so the race is fully plugged without using cpu_dying_mask
2) Replacing the cpu_dying_mask logic with hotplug core internal state which is exposed to the scheduler with a properly documented function.
The series is also available from git:
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git smp/dying_mask
Thanks
tglx
--- include/linux/cpuhotplug.h | 2 - include/linux/cpumask.h | 21 ---------------- kernel/cpu.c | 45 +++++++++++++++++++++++++++++------ kernel/sched/core.c | 4 +-- kernel/smpboot.h | 2 + lib/percpu_counter.c | 57 +++++++++++++++++++-------------------------- 6 files changed, 67 insertions(+), 64 deletions(-)