Skip to content

net: phy: phy_interface_is_rgmii update, drop phy_interface_is_sgmii

Nishanth Menon u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 6 repliesIn review

Changes in v3 from the cover letter

* Dropped fixing up sgmii api, instead: just fixup the phy driver, drop the api
* picked reviewed by for the rgmii

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: phy: dp83867: Explicitly check against sgmiidrivers/net/phy/dp83867.c+1 -12 replies
2/3net: phy: Drop phy_interface_is_sgmiiinclude/phy.h+0 -122 replies
3/3net: phy: Make phy_interface_is_rgmii a switch statementinclude/phy.h+9 -22 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarek VasutMarek BehúnRamon Fried
1/3R-b
2/3R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH V3 0/3] net: phy: phy_interface_is_rgmii update, drop phy_interface_is_sgmii

Originally reported by Tom[1], turned out to be that recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux") reordered the enum definitions which in turn broke the range checks.

we are left with two options:
a) check against explicit values to help reuse as much as possible and let compiler optimize where applicable
or
b) be very explicit in phy drivers and drop these helpers.

I have chosen to go with (a) approach.

Tested on am64x, though the dp83867 is used elsewhere as well.

Changes since V2:
* Dropped fixing up sgmii api, instead: just fixup the phy driver, drop the api
* picked reviewed by for the rgmii

V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

Nishanth Menon (3):
net: phy: dp83867: Explicitly check against sgmii
net: phy: Drop phy_interface_is_sgmii
net: phy: Make phy_interface_is_rgmii a switch statement

 drivers/net/phy/dp83867.c |  2 +-
 include/phy.h             | 23 +++++++++--------------
 2 files changed, 10 insertions(+), 15 deletions(-)
Signature · 1 line
2.40.0