net: phy: phy_interface_is_rgmii update, drop phy_interface_is_sgmii
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest3 patches 6 repliesIn review
Changes in v3 from the cover letter
* Dropped fixing up sgmii api, instead: just fixup the phy driver, drop the api
* picked reviewed by for the rgmii
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: phy: dp83867: Explicitly check against sgmiidrivers/ | +1 | 2 replies | |
| 2/3 | net: phy: Drop phy_interface_is_sgmiiinclude/ | +0 | 2 replies | |
| 3/3 | net: phy: Make phy_interface_is_rgmii a switch statementinclude/ | +9 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Marek Vasut | Marek Behún | Ramon Fried |
|---|---|---|---|
| 1/3 | R-b | ||
| 2/3 | R-b | ||
| 3/3 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH V3 0/3] net: phy: phy_interface_is_rgmii update, drop phy_interface_is_sgmii
Originally reported by Tom[1], turned out to be that recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux") reordered the enum definitions which in turn broke the range checks.
we are left with two options:
a) check against explicit values to help reuse as much as possible and let compiler optimize where applicable
or
b) be very explicit in phy drivers and drop these helpers.
I have chosen to go with (a) approach.
Tested on am64x, though the dp83867 is used elsewhere as well.
Changes since V2:
* Dropped fixing up sgmii api, instead: just fixup the phy driver, drop the api
* picked reviewed by for the rgmii
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
Nishanth Menon (3):
net: phy: dp83867: Explicitly check against sgmii
net: phy: Drop phy_interface_is_sgmii
net: phy: Make phy_interface_is_rgmii a switch statement
drivers/net/phy/dp83867.c | 2 +- include/phy.h | 23 +++++++++-------------- 2 files changed, 10 insertions(+), 15 deletions(-)
Signature · 1 line
2.40.0