Skip to content

ixgbe: Multiple RSS bugfixes

Joe Damato intel-wired-lan netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Include Reviewed-by tags from Sridhar Samudrala.
- Fix title of patch 2/2:
previously: ixgbe: Allow ixgbe to reset default flow hash
now: ixgbe: Enable setting RSS table to default values
- No functional changes.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ixgbe: Allow flow hash to be set via ethtooldrivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c+2 -22 replies
2/2ixgbe: Enable setting RSS table to default valuesdrivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c+10 -92 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSridhar SamudralaPucha Himasekhar Reddy
1/2R-b T-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/2] ixgbe: Multiple RSS bugfixes

Greetings:

Welcome to v2.

See the v2 change summary below; v2 contains only cosmetic changes to commit messages. No other changes were made from v1.

This series fixes two bugs I stumbled on with ixgbe:

1. The flow hash cannot be set manually with ethool at all. Patch 1/2 addresses this by fixing what appears to be a small bug in set_rxfh in ixgbe. See the commit message for more details.

2. Once the above patch is applied and the flow hash can be set, resetting the flow hash to default fails if the number of queues is greater than the number of queues supported by RSS. Other drivers (like i40e) will reset the flowhash to use the maximum number of queues supported by RSS even if the queue count configured is larger. In other
words: some queues will not have packets distributed to them by the RSS hash if the queue count is too large. Patch 2/2 allows the user to reset ixgbe to default and the flowhash is set correctly to either the maximum number of queues supported by RSS or the configured queue count, whichever is smaller.

I believe this is correct and it mimics the behavior of i40e; ethtool -X $iface default should probably always succeed even if all the queues cannot be utilized. See the commit message for more details and examples.

I tested these on an ixgbe system I have access to and they appear to work as intended, but I would appreciate a review by the experts on this list :)

Thanks,
Joe

v2:
- Include Reviewed-by tags from Sridhar Samudrala.
- Fix title of patch 2/2:
previously: ixgbe: Allow ixgbe to reset default flow hash
now: ixgbe: Enable setting RSS table to default values
- No functional changes.

Joe Damato (2):
ixgbe: Allow flow hash to be set via ethtool
ixgbe: Enable setting RSS table to default values

 .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)
Signature · 6 lines
2.25.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan